Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756531AbcKVQlU (ORCPT ); Tue, 22 Nov 2016 11:41:20 -0500 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:53622 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756512AbcKVQlS (ORCPT ); Tue, 22 Nov 2016 11:41:18 -0500 From: Liviu Dudau To: Eric Engestrom Cc: David Airlie , DRI devel , LKML , Rob Clark , Jani Nikula , Daniel Vetter Subject: [PATCH] drm: check for NULL parameter in exported drm_get_format_name() function. Date: Tue, 22 Nov 2016 16:41:06 +0000 Message-Id: <20161122164106.31852-1-Liviu.Dudau@arm.com> X-Mailer: git-send-email 2.10.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1024 Lines: 31 drm_get_format_name() de-references the buf parameter without checking if the pointer was not NULL. Given that the function is EXPORT-ed, lets sanitise the parameters before proceeding. Fixes: b3c11ac267d461d3d5 ("drm: move allocation out of drm_get_format_name()) Cc: Eric Engestrom Cc: Rob Clark Cc: Jani Nikula Cc: Daniel Vetter Signed-off-by: Liviu Dudau --- drivers/gpu/drm/drm_fourcc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c index 90d2cc8..0a3ff0b 100644 --- a/drivers/gpu/drm/drm_fourcc.c +++ b/drivers/gpu/drm/drm_fourcc.c @@ -85,6 +85,9 @@ EXPORT_SYMBOL(drm_mode_legacy_fb_format); */ const char *drm_get_format_name(uint32_t format, struct drm_format_name_buf *buf) { + if (!buf) + return NULL; + snprintf(buf->str, sizeof(buf->str), "%c%c%c%c %s-endian (0x%08x)", printable_char(format & 0xff), -- 2.10.2