Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933584AbcKVRrb (ORCPT ); Tue, 22 Nov 2016 12:47:31 -0500 Received: from mail-pg0-f46.google.com ([74.125.83.46]:32922 "EHLO mail-pg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932501AbcKVRr3 (ORCPT ); Tue, 22 Nov 2016 12:47:29 -0500 Subject: Re: [PATCH] clk: bcm: Fix unmet Kconfig dependencies for CLK_BCM_63XX To: Florian Fainelli , linux-kernel@vger.kernel.org References: <20161122174329.11592-1-f.fainelli@gmail.com> Cc: bcm-kernel-feedback-list@broadcom.com, Michael Turquette , Stephen Boyd , Jon Mason , "open list:COMMON CLK FRAMEWORK" From: Ray Jui Message-ID: Date: Tue, 22 Nov 2016 09:47:26 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:50.0) Gecko/20100101 Thunderbird/50.0 MIME-Version: 1.0 In-Reply-To: <20161122174329.11592-1-f.fainelli@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1387 Lines: 39 Hi Florian, On 11/22/2016 9:43 AM, Florian Fainelli wrote: > With commit f4e871509959 ("clk: iproc: Make clocks visible options"), > COMMON_CLK_IPROC gained a dependency on ARCH_BCM_IPROC, yet CLK_BCM_63XX > also selects that option, this causes the following Kconfig warning: > > warning: (CLK_BCM_63XX) selects COMMON_CLK_IPROC which has unmet direct > dependencies ((ARCH_BCM_IPROC || COMPILE_TEST) && COMMON_CLK) > > Fix this by adding proper depends/default for COMMON_CLK_IPROC > > Fixes: f4e871509959 ("clk: iproc: Make clocks visible options") > Signed-off-by: Florian Fainelli > --- > drivers/clk/bcm/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/bcm/Kconfig b/drivers/clk/bcm/Kconfig > index f21e9b7afd1a..80de9fc2e833 100644 > --- a/drivers/clk/bcm/Kconfig > +++ b/drivers/clk/bcm/Kconfig > @@ -20,9 +20,9 @@ config CLK_BCM_KONA > > config COMMON_CLK_IPROC > bool "Broadcom iProc clock support" > - depends on ARCH_BCM_IPROC || COMPILE_TEST > + depends on ARCH_BCM_IPROC || ARCH_BCM_63XX || COMPILE_TEST > depends on COMMON_CLK > - default ARCH_BCM_IPROC > + default ARCH_BCM_IPROC || ARCH_BCM_63XX > help > Enable common clock framework support for Broadcom SoCs > based on the iProc architecture > This change looks good! Thanks. Reviewed-by: Ray Jui