Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756108AbcKVRzM (ORCPT ); Tue, 22 Nov 2016 12:55:12 -0500 Received: from fmailer.gwdg.de ([134.76.11.16]:44975 "EHLO fmailer.gwdg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932501AbcKVRzK (ORCPT ); Tue, 22 Nov 2016 12:55:10 -0500 Date: Tue, 22 Nov 2016 18:55:04 +0100 From: Andre Noll To: Eric Dumazet Cc: "Duyck, Alexander H" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "ast@kernel.org" , "stable@vger.kernel.org" , "willemb@google.com" , "jslaby@suse.cz" , "davem@davemloft.net" , "yibyang@cisco.com" Subject: Re: Linux 4.4.34 Message-ID: <20161122175504.GD19939@tuebingen.mpg.de> References: <20161121092855.GA20976@kroah.com> <20161122165912.GA19939@tuebingen.mpg.de> <20161122170654.GA20022@kroah.com> <1479836511.681.165.camel@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5p8PegU4iirBW1oA" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1329 Lines: 49 --5p8PegU4iirBW1oA Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 22, 09:46, Eric Dumazet wrote > This is an aliasing problem. > Tom code is hard to read and understand. >=20 > Andre, could you try : >=20 > diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c > index 69e4463a4b1b..b045980faaea 100644 > --- a/net/core/flow_dissector.c > +++ b/net/core/flow_dissector.c > @@ -157,6 +157,7 @@ bool __skb_flow_dissect(const struct sk_buff *skb, > memcpy(key_eth_addrs, ð->h_dest, sizeof(*key_eth_addrs= )); > } >=20 > + barrier(); > again: > switch (proto) { > case htons(ETH_P_IP): { This patch on top of v4.4.34 makes no difference: I'm still getting the panic in eth_type_trans(). Andre --=20 Max Planck Institute for Developmental Biology Spemannstra=C3=9Fe 35, 72076 T=C3=BCbingen, Germany. Phone: (+49) 7071 601 = 829 http://people.tuebingen.mpg.de/maan/ --5p8PegU4iirBW1oA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlg0hngACgkQWto1QDEAkw8wcwCfcEfoohj9KFFEoFmgQSF1wuqp 60QAnA5oxYBTD3ZLaulin3QidOipVCdW =GtRL -----END PGP SIGNATURE----- --5p8PegU4iirBW1oA--