Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934027AbcKVSGK (ORCPT ); Tue, 22 Nov 2016 13:06:10 -0500 Received: from fmailer.gwdg.de ([134.76.11.16]:43750 "EHLO fmailer.gwdg.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932768AbcKVSGJ (ORCPT ); Tue, 22 Nov 2016 13:06:09 -0500 Date: Tue, 22 Nov 2016 19:06:05 +0100 From: Andre Noll To: Eric Dumazet Cc: "Duyck, Alexander H" , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "ast@kernel.org" , "stable@vger.kernel.org" , "willemb@google.com" , "jslaby@suse.cz" , "davem@davemloft.net" , "yibyang@cisco.com" Subject: Re: Linux 4.4.34 Message-ID: <20161122180605.GE19939@tuebingen.mpg.de> References: <20161121092855.GA20976@kroah.com> <20161122165912.GA19939@tuebingen.mpg.de> <20161122170654.GA20022@kroah.com> <1479836511.681.165.camel@intel.com> <20161122175504.GD19939@tuebingen.mpg.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="o0ZfoUVt4BxPQnbU" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1735 Lines: 61 --o0ZfoUVt4BxPQnbU Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 22, 09:56, Eric Dumazet wrote > >> @@ -157,6 +157,7 @@ bool __skb_flow_dissect(const struct sk_buff *skb, > >> memcpy(key_eth_addrs, ð->h_dest, sizeof(*key_eth_ad= drs)); > >> } > >> > >> + barrier(); > >> again: > >> switch (proto) { > >> case htons(ETH_P_IP): { > > > > This patch on top of v4.4.34 makes no difference: I'm still getting > > the panic in eth_type_trans(). > > >=20 > What compiler are you using exactly ? gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3, as shipped with Ubuntu-12.04. I've also tried gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4 from Ubuntu-14.04. No difference. > diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c > index 69e4463a4b1b..48791f372aa2 100644 > --- a/net/core/flow_dissector.c > +++ b/net/core/flow_dissector.c > @@ -551,6 +551,7 @@ bool __skb_flow_dissect(const struct sk_buff *skb, >=20 > key_control->thoff =3D (u16)nhoff; > out: > + barrier(); > key_basic->n_proto =3D proto; > key_basic->ip_proto =3D ip_proto; No luck: Still the same panic. Andre --=20 Max Planck Institute for Developmental Biology Spemannstra=C3=9Fe 35, 72076 T=C3=BCbingen, Germany. Phone: (+49) 7071 601 = 829 http://people.tuebingen.mpg.de/maan/ --o0ZfoUVt4BxPQnbU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlg0iQ0ACgkQWto1QDEAkw9jJACfYEXrJJxZhgk/bm7owPWnsJnK o+IAoKI/jDwvD7eOvCx8aQLxFviQDmX1 =9hEk -----END PGP SIGNATURE----- --o0ZfoUVt4BxPQnbU--