Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934598AbcKVSmV (ORCPT ); Tue, 22 Nov 2016 13:42:21 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:32953 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934562AbcKVSmT (ORCPT ); Tue, 22 Nov 2016 13:42:19 -0500 Date: Tue, 22 Nov 2016 10:42:15 -0800 From: Brian Norris To: Zach Brown Cc: dwmw2@infradead.org, boris.brezillon@free-electrons.com, richard@nod.at, dedekind1@gmail.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v5 2/5] mtd: ubi: use 'max_bad_blocks' to compute bad_peb_limit if available Message-ID: <20161122184215.GA77253@google.com> References: <1479757899-6849-1-git-send-email-zach.brown@ni.com> <1479757899-6849-3-git-send-email-zach.brown@ni.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479757899-6849-3-git-send-email-zach.brown@ni.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1463 Lines: 44 On Mon, Nov 21, 2016 at 01:51:36PM -0600, Zach Brown wrote: > From: Jeff Westfahl > > Use the MTD function 'max_bad_blocks' to compute the UBI bad_peb_limit, > if the function is implemented for an MTD and doesn't return an error. I'm not exactly a UBI expert here, but it seems reasonable that we should adjust the Kconfig documentation for MTD_UBI_BEB_LIMIT to further emphasize that it's a default, if the value can't be determined by other means. > Signed-off-by: Jeff Westfahl > Signed-off-by: Zach Brown > Acked-by: Boris Brezillon > --- > drivers/mtd/ubi/build.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c > index 85d54f3..e9940a9 100644 > --- a/drivers/mtd/ubi/build.c > +++ b/drivers/mtd/ubi/build.c > @@ -584,6 +584,10 @@ static int get_bad_peb_limit(const struct ubi_device *ubi, int max_beb_per1024) > int limit, device_pebs; > uint64_t device_size; > > + limit = mtd_max_bad_blocks(ubi->mtd, 0, ubi->mtd->size); > + if (limit > 0) > + return limit; Are you sure you want to even override the user-provided max_beb_per1024 value taken from the mtd= line? I'd think if someone went as far as to specify this in the kernel command line, they don't expect it to get overridden. Just my two cents. Brian > + > if (!max_beb_per1024) > return 0; > > -- > 2.7.4 >