Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934620AbcKVSmp (ORCPT ); Tue, 22 Nov 2016 13:42:45 -0500 Received: from mail-wj0-f174.google.com ([209.85.210.174]:34900 "EHLO mail-wj0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932421AbcKVSmn (ORCPT ); Tue, 22 Nov 2016 13:42:43 -0500 X-Greylist: delayed 491 seconds by postgrey-1.27 at vger.kernel.org; Tue, 22 Nov 2016 13:42:42 EST MIME-Version: 1.0 In-Reply-To: <20161122195549.GB29812@avx2> References: <20161122195549.GB29812@avx2> From: Vegard Nossum Date: Tue, 22 Nov 2016 19:34:29 +0100 Message-ID: Subject: Re: [PATCH] proc: calculate /proc/* and /proc/*/task/* nlink at init time To: Alexey Dobriyan Cc: Andrew Morton , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 528 Lines: 19 On 22 November 2016 at 20:55, Alexey Dobriyan wrote: > Runtime nlink calculation works but meh. I don't know how to do it > at compile time, but I know how to do it at init time. > > Shift "2+" part into init time as a bonus. Couple of small suggestions: - rename set_proc_pid_nlink() to proc_pid_nlink_init() to make it 100% clear it's a one time thing - move pid_entry_nlink() down to just above where it is called Either way, Acked-by/Reviewed-by: Vegard Nossum Vegard