Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934058AbcKVTov (ORCPT ); Tue, 22 Nov 2016 14:44:51 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:60312 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934007AbcKVTou (ORCPT ); Tue, 22 Nov 2016 14:44:50 -0500 Date: Tue, 22 Nov 2016 14:44:44 -0500 (EST) Message-Id: <20161122.144444.2261159964230408258.davem@davemloft.net> To: eric.dumazet@gmail.com Cc: maan@tuebingen.mpg.de, jiri@resnulli.us, alexander.h.duyck@intel.com, edumazet@google.com, linux-kernel@vger.kernel.org, ast@kernel.org, willemb@google.com, gregkh@linuxfoundation.org, jslaby@suse.cz, yibyang@cisco.com, netdev@vger.kernel.org Subject: Re: [PATCH net] flow_dissect: call init_default_flow_dissectors() earlier From: David Miller In-Reply-To: <1479842250.8455.452.camel@edumazet-glaptop3.roam.corp.google.com> References: <1479838123.681.173.camel@intel.com> <20161122182258.GF19939@tuebingen.mpg.de> <1479842250.8455.452.camel@edumazet-glaptop3.roam.corp.google.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 22 Nov 2016 10:45:23 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 951 Lines: 23 From: Eric Dumazet Date: Tue, 22 Nov 2016 11:17:30 -0800 > From: Eric Dumazet > > Andre Noll reported panics after my recent fix (commit 34fad54c2537 > "net: __skb_flow_dissect() must cap its return value") > > After some more headaches, Alexander root caused the problem to > init_default_flow_dissectors() being called too late, in case > a network driver like IGB is not a module and receives DHCP message > very early. > > Fix is to call init_default_flow_dissectors() much earlier, > as it is a core infrastructure and does not depend on another > kernel service. > > Fixes: 06635a35d13d4 ("flow_dissect: use programable dissector in skb_flow_dissect and friends") > Signed-off-by: Eric Dumazet > Reported-by: Andre Noll > Diagnosed-by: Alexander Duyck Applied and queued up for -stable, I'll try to fast-track this.