Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756751AbcKVUqv (ORCPT ); Tue, 22 Nov 2016 15:46:51 -0500 Received: from vern.gendns.com ([206.190.152.46]:39932 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756019AbcKVUqt (ORCPT ); Tue, 22 Nov 2016 15:46:49 -0500 Subject: Re: [PATCH v6 1/5] USB: ohci: da8xx: use ohci priv data instead of globals To: Axel Haslam , gregkh@linuxfoundation.org, nsekhar@ti.com, khilman@baylibre.com References: <20161121163014.28008-1-ahaslam@baylibre.com> <20161121163014.28008-2-ahaslam@baylibre.com> Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org From: David Lechner Message-ID: Date: Tue, 22 Nov 2016 14:46:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161121163014.28008-2-ahaslam@baylibre.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 517 Lines: 18 On 11/21/2016 10:30 AM, Axel Haslam wrote: > Instead of global variables, use the extra_priv_size of > the ohci driver. > > We cannot yet move the ocic mask because this is used on > the interrupt handler which is registerded through platform s/registerded/registered/ > data and does not have an hcd pointer. This will be moved > on a later patch. > > Signed-off-by: Axel Haslam > --- Looks good to me (other than the spelling error above). Tested-by: David Lechner