Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755726AbcKVWXb (ORCPT ); Tue, 22 Nov 2016 17:23:31 -0500 Received: from vern.gendns.com ([206.190.152.46]:46345 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932346AbcKVWX3 (ORCPT ); Tue, 22 Nov 2016 17:23:29 -0500 Subject: Re: [PATCH v2] ARM: dts: da850: add the mstpri and ddrctl nodes To: Bartosz Golaszewski , Kevin Hilman , Michael Turquette , Sekhar Nori , Rob Herring , Frank Rowand , Mark Rutland , Peter Ujfalusi , Russell King References: <1479207611-18028-1-git-send-email-bgolaszewski@baylibre.com> Cc: linux-devicetree , David Airlie , LKML , linux-drm , Tomi Valkeinen , Jyri Sarha , arm-soc , Laurent Pinchart From: David Lechner Message-ID: Date: Tue, 22 Nov 2016 16:23:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1479207611-18028-1-git-send-email-bgolaszewski@baylibre.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1238 Lines: 44 On 11/15/2016 05:00 AM, Bartosz Golaszewski wrote: > Add the nodes for the MSTPRI configuration and DDR2/mDDR memory > controller drivers to da850.dtsi. > > Signed-off-by: Bartosz Golaszewski > --- > v1 -> v2: > - moved the priority controller node above the cfgchip node > - renamed added nodes to better reflect their purpose > > arch/arm/boot/dts/da850.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi > index 1bb1f6d..412eec6 100644 > --- a/arch/arm/boot/dts/da850.dtsi > +++ b/arch/arm/boot/dts/da850.dtsi > @@ -210,6 +210,10 @@ > }; > > }; > + prictrl: priority-controller@14110 { > + compatible = "ti,da850-mstpri"; > + reg = <0x14110 0x0c>; I think we should add status = "disabled"; here and let boards opt in. > + }; > cfgchip: chip-controller@1417c { > compatible = "ti,da830-cfgchip", "syscon", "simple-mfd"; > reg = <0x1417c 0x14>; > @@ -451,4 +455,8 @@ > 1 0 0x68000000 0x00008000>; > status = "disabled"; > }; > + memctrl: memory-controller@b0000000 { > + compatible = "ti,da850-ddr-controller"; > + reg = <0xb0000000 0xe8>; same here. status = "disabled"; > + }; > }; >