Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755952AbcKWAnI (ORCPT ); Tue, 22 Nov 2016 19:43:08 -0500 Received: from mga05.intel.com ([192.55.52.43]:1909 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755842AbcKWAnG (ORCPT ); Tue, 22 Nov 2016 19:43:06 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,535,1473145200"; d="scan'208";a="789706886" Date: Tue, 22 Nov 2016 19:43:03 -0500 From: "ira.weiny" To: Bhumika Goyal Cc: julia.lawall@lip6.fr, mike.marciniszyn@intel.com, dennis.dalessandro@intel.com, dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] infiniband: hw: hfi1: constify mmu_notifier_ops structure Message-ID: <20161123004303.GB27968@phlsvsds.ph.intel.com> References: <1479548868-13563-1-git-send-email-bhumirks@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479548868-13563-1-git-send-email-bhumirks@gmail.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2192 Lines: 76 On Sat, Nov 19, 2016 at 03:17:48PM +0530, Bhumika Goyal wrote: > Declare the structure mmu_notifier_ops as const as it is only stored in > the ops field of a mmu_notifier structure. The ops field is of type > const struct mmu_notifier_ops *, so mmu_notifier_ops structures having > this property can be declared as const. > Done using coccinelle: > @r1 disable optional_qualifier @ > identifier i; > position p; > @@ > static struct mmu_notifier_ops i@p = {...}; > > @ok1@ > identifier r1.i; > position p; > struct mmu_rb_handler handler; > @@ > handler.mn.ops=&i@p > > @bad@ > position p!={r1.p,ok1.p}; > identifier r1.i; > @@ > i@p > > @depends on !bad disable optional_qualifier@ > identifier r1.i; > @@ > static > +const > struct mmu_notifier_ops i={...}; > > @depends on !bad disable optional_qualifier@ > identifier r1.i; > @@ > +const > struct mmu_notifier_ops i; > > File size before: > text data bss dec hex filename > 3566 72 16 3654 e46 > drivers/infiniband/hw/hfi1/mmu_rb.o > > File size after: > text data bss dec hex filename > 3658 0 16 3674 e5a > drivers/infiniband/hw/hfi1/mmu_rb.o > > Signed-off-by: Bhumika Goyal Reviewed-by: Ira Weiny > --- > drivers/infiniband/hw/hfi1/mmu_rb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/hfi1/mmu_rb.c b/drivers/infiniband/hw/hfi1/mmu_rb.c > index 7ad3089..ccbf52c 100644 > --- a/drivers/infiniband/hw/hfi1/mmu_rb.c > +++ b/drivers/infiniband/hw/hfi1/mmu_rb.c > @@ -81,7 +81,7 @@ static void do_remove(struct mmu_rb_handler *handler, > struct list_head *del_list); > static void handle_remove(struct work_struct *work); > > -static struct mmu_notifier_ops mn_opts = { > +static const struct mmu_notifier_ops mn_opts = { > .invalidate_page = mmu_notifier_page, > .invalidate_range_start = mmu_notifier_range_start, > }; > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html