Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756511AbcKWBRT (ORCPT ); Tue, 22 Nov 2016 20:17:19 -0500 Received: from anchovy2.45ru.net.au ([203.30.46.146]:47783 "EHLO anchovy.45ru.net.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756474AbcKWBRR (ORCPT ); Tue, 22 Nov 2016 20:17:17 -0500 Subject: Re: [PATCH 2/2] power: supply: add sbs-charger driver To: Nicola Saenz Julienne , sre@kernel.org References: <1479751491-8849-1-git-send-email-nicolas.saenz@prodys.net> <1479751491-8849-3-git-send-email-nicolas.saenz@prodys.net> Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org From: Phil Reid Message-ID: Date: Wed, 23 Nov 2016 09:17:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1028 Lines: 34 On 23/11/2016 09:06, Phil Reid wrote: > G'day Nicola, > > On 22/11/2016 02:04, Nicola Saenz Julienne wrote: >> This adds support for sbs-charger compilant chips as defined here: >> http://sbs-forum.org/specs/sbc110.pdf >> > > You may want to look at the series: power: supply: sbs-manager add driver. > http://www.spinics.net/lists/linux-i2c/msg26383.html > > This is the same thing that Karl-Heinz and myself particpated on. > > We've had some trouble getting the device tree binding approved thou. > > In particular it handles multiple sbs-batteries thru an i2c mux. > > Have a look and let me know what you think. Sebastians comment on the irq thing looks interesting > There does look to be some nice additional features in your driver. > > I've been distracted with other things but if you want to progress it I'm happy to help with testing etc. > > Dual battery support is a must for me thou. > Sorry Ignore all that. Just realised its a different device. charger vs combined manager / charger. -- Regards Phil Reid