Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756199AbcKWCZQ (ORCPT ); Tue, 22 Nov 2016 21:25:16 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:47590 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755734AbcKWCZO (ORCPT ); Tue, 22 Nov 2016 21:25:14 -0500 Subject: Re: [PATCH V6 1/2] PCI/ACPI: Provide acpi_get_rc_resources() for ARM64 platform To: Tomasz Nowicki , , , , , , References: <1479816529-97410-1-git-send-email-liudongdong3@huawei.com> <1479816529-97410-2-git-send-email-liudongdong3@huawei.com> <56c1d551-a18d-8ee0-eb3c-b2b7d5341161@semihalf.com> <7c6b49b1-fa79-d0b0-180e-25a342350245@huawei.com> CC: , , , , , , From: Dongdong Liu Message-ID: Date: Wed, 23 Nov 2016 10:24:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <7c6b49b1-fa79-d0b0-180e-25a342350245@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.63.141.93] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2469 Lines: 88 Hi Tomasz 在 2016/11/23 9:44, Dongdong Liu 写道: > Hi Tomasz > > 在 2016/11/22 20:32, Tomasz Nowicki 写道: >> Hi Dongdong, >> >> On 22.11.2016 13:08, Dongdong Liu wrote: >>> The acpi_get_rc_resources() is used to get the RC register address that can >>> not be described in MCFG. It takes the _HID&segment to look for and returns >>> the RC address resource. Use PNP0C02 devices to describe such RC address >>> resource. Use _UID to match segment to tell which root bus the PNP0C02 >>> resource belong to. >>> >>> Signed-off-by: Dongdong Liu >>> Signed-off-by: Tomasz Nowicki >>> --- >>> drivers/pci/pci-acpi.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++ >>> drivers/pci/pci.h | 4 +++ >>> 2 files changed, 73 insertions(+) >>> >>> diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c >>> index d966d47..76fd6f4 100644 >>> --- a/drivers/pci/pci-acpi.c >>> +++ b/drivers/pci/pci-acpi.c >>> @@ -29,6 +29,75 @@ >>> 0x91, 0x17, 0xea, 0x4d, 0x19, 0xc3, 0x43, 0x4d >>> }; >>> >>> +#ifdef CONFIG_ARM64 >>> +static struct resource *acpi_get_rc_addr(struct acpi_device *adev) >>> +{ >>> + struct resource_entry *entry; >>> + struct list_head list; >>> + unsigned long flags; >>> + int ret; >>> + struct resource *res; >>> + >>> + INIT_LIST_HEAD(&list); >>> + flags = IORESOURCE_MEM; >>> + ret = acpi_dev_get_resources(adev, &list, >>> + acpi_dev_filter_resource_type_cb, >>> + (void *) flags); >>> + if (ret <= 0) >>> + return NULL; >>> + >>> + entry = list_first_entry(&list, struct resource_entry, node); >>> + res = entry->res; >> >> You return "res" memory pointer and... >> >>> + acpi_dev_free_resource_list(&list); >> >> free it here. > > acpi_dev_free_resource_list > --->resource_list_free > --->resource_list_destroy_entry > --->resource_list_free_entry > --->kfree(entry) > only free entry not free entry->res, so this is ok. Sorry I am wrong, ignore this. > > Thanks > Dongdong >> >>> + return res; >>> +} >> >> >> We either allocate memory for res here or get it from the caller. Yes, you are right.I prefer to get if from the caller as PATCH V5 shows. Thanks Dongdong >> >> Tomasz >> >> . >> > > _______________________________________________ > linuxarm mailing list > linuxarm@huawei.com > http://rnd-openeuler.huawei.com/mailman/listinfo/linuxarm