Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756110AbcKWHfm (ORCPT ); Wed, 23 Nov 2016 02:35:42 -0500 Received: from host.buserror.net ([209.198.135.123]:52617 "EHLO host.buserror.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752592AbcKWHfl (ORCPT ); Wed, 23 Nov 2016 02:35:41 -0500 Date: Wed, 23 Nov 2016 01:35:28 -0600 From: Scott Wood To: Zhao Qiang Cc: balbi@kernel.org, gregkh@linuxfoundation.org, xiaobo.xie@nxp.com, linux-kernel@vger.kernel.org, pku.leo@gmail.com, linuxppc-dev@lists.ozlabs.org Message-ID: <20161123073528.GA3785@home.buserror.net> References: <1475032531-10263-1-git-send-email-qiang.zhao@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475032531-10263-1-git-send-email-qiang.zhao@nxp.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 50.171.225.118 X-SA-Exim-Mail-From: oss@buserror.net X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * -15 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Subject: Re: [v7] QE: remove PPCisms for QE X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:57:07 +0000) X-SA-Exim-Scanned: Yes (on host.buserror.net) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3552 Lines: 54 On Wed, Sep 28, 2016 at 11:15:31AM +0800, Zhao Qiang wrote: > QE was supported on PowerPC, and dependent on PPC, > Now it is supported on other platforms. so remove PPCisms. > > Signed-off-by: Zhao Qiang > --- Changelog should be something like: soc/fsl/qe: Cleanups and portability fixes QE was supported on PowerPC, and dependent on PPC. In preparation for supporting on other platforms, remove some PPCisms. The PPC kconfig dependency is moved from the QE core into the individual QE peripheral drivers, to allow portability work to occur on them separately. > diff --git a/include/soc/fsl/qe/qe.h b/include/soc/fsl/qe/qe.h > index 70339d7..f7a14f2 100644 > --- a/include/soc/fsl/qe/qe.h > +++ b/include/soc/fsl/qe/qe.h > @@ -21,7 +21,6 @@ > #include > #include > #include > -#include > #include > #include > #include When building corenet32_smp_defconfig, I get this: /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:262:31: error: 'BD_SC_READY' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:266:31: error: 'BD_SC_WRAP' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:348:3: error: 'BD_SC_READY' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:350:31: error: 'BD_SC_WRAP' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:477:16: error: 'BD_SC_EMPTY' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:501:9: error: 'BD_SC_BR' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:501:20: error: 'BD_SC_FR' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:501:31: error: 'BD_SC_PR' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:501:42: error: 'BD_SC_OV' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:512:3: error: 'BD_SC_ID' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:514:31: error: 'BD_SC_WRAP' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:605:26: error: 'BD_SC_EMPTY' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:605:40: error: 'BD_SC_INTRPT' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:613:25: error: 'BD_SC_WRAP' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:926:27: error: 'BD_SC_EMPTY' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:926:41: error: 'BD_SC_OV' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:928:29: error: 'BD_SC_FR' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:928:40: error: 'BD_SC_PR' undeclared (first use in this function) /home/scott/fsl/git/linux/upstream/drivers/tty/serial/ucc_uart.c:930:29: error: 'BD_SC_BR' undeclared (first use in this function) -Scott