Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934252AbcKWJGk (ORCPT ); Wed, 23 Nov 2016 04:06:40 -0500 Received: from aserp1050.oracle.com ([141.146.126.70]:18082 "EHLO aserp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756334AbcKWJFd (ORCPT ); Wed, 23 Nov 2016 04:05:33 -0500 From: Vaishali Thakkar To: mmarek@suse.com Cc: julia.lawall@lip6.fr, gilles.muller@lip6.fr, nicolas.palix@imag.fr, lars@metafoo.de, cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org, Vaishali Thakkar Subject: [PATCH v4 3/3] Coccinelle: misc: Add support for devm variant in all modes Date: Wed, 23 Nov 2016 14:16:42 +0530 Message-Id: X-Mailer: git-send-email 2.1.4 In-Reply-To: References: X-Source-IP: aserp1040.oracle.com [141.146.126.69] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1532 Lines: 64 Add missing support for the devm_request_threaded_irq in the rules of context, report and org modes. Misc: ---- To be consistent with other scripts, change confidence level of the script to 'Moderate'. Signed-off-by: Vaishali Thakkar Acked-by: Julia Lawall --- Changes since v3: - No changes in this patch Changes since v2: - Add missing initialization of metavariables Changes since v1: - Split patch in to the patchset --- scripts/coccinelle/misc/irqf_oneshot.cocci | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/scripts/coccinelle/misc/irqf_oneshot.cocci b/scripts/coccinelle/misc/irqf_oneshot.cocci index cec3672..58c2578 100644 --- a/scripts/coccinelle/misc/irqf_oneshot.cocci +++ b/scripts/coccinelle/misc/irqf_oneshot.cocci @@ -5,7 +5,7 @@ /// So pass the IRQF_ONESHOT flag in this case. /// // -// Confidence: Good +// Confidence: Moderate // Comments: // Options: --no-includes @@ -79,16 +79,25 @@ devm_request_threaded_irq@p(dev, irq, NULL, thread_fn, ) @depends on context@ -expression irq; +expression dev, irq; position p != {r1.p,r2.p}; @@ +( *request_threaded_irq@p(irq, NULL, ...) +| +*devm_request_threaded_irq@p(dev, irq, NULL, ...) +) + @match depends on report || org@ -expression irq; +expression dev, irq; position p != {r1.p,r2.p}; @@ +( request_threaded_irq@p(irq, NULL, ...) +| +devm_request_threaded_irq@p(dev, irq, NULL, ...) +) @script:python depends on org@ p << match.p; -- 2.1.4