Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934921AbcKWJ40 (ORCPT ); Wed, 23 Nov 2016 04:56:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38060 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934143AbcKWJzi (ORCPT ); Wed, 23 Nov 2016 04:55:38 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20161123093122.GB2071@wunner.de> References: <20161123093122.GB2071@wunner.de> <147986054870.13790.8640536414645705863.stgit@warthog.procyon.org.uk> <147986057768.13790.3027173260868896792.stgit@warthog.procyon.org.uk> To: Lukas Wunner Cc: dhowells@redhat.com, linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <31280.1479894780.1@warthog.procyon.org.uk> Date: Wed, 23 Nov 2016 09:53:00 +0000 Message-ID: <31281.1479894780@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 23 Nov 2016 09:53:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 621 Lines: 15 Lukas Wunner wrote: > It just occurred to me that the boot_params struct is populated in > make_boot_params(), perhaps it makes sense to move this line there. > Otherwise LGTM. Ummm... Looking at arch/x86/boot/compressed/head_64.S, make_boot_params() is only called if the stub is entered through efi_pe_entry, not if entered through efi64_stub_entry, whereas efi_main() is called in both cases. I think entry through efi32_stub_entry may also skip make_boot_params(). The comment on make_boot_params() suggests that this function is only used if whoever booted the kernel didn't supply it. David