Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934824AbcKWJ4Y (ORCPT ); Wed, 23 Nov 2016 04:56:24 -0500 Received: from avasout05.plus.net ([84.93.230.250]:41900 "EHLO avasout05.plus.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934039AbcKWJ4K (ORCPT ); Wed, 23 Nov 2016 04:56:10 -0500 X-CM-Score: 0.00 X-CNFS-Analysis: v=2.2 cv=Qskc5h6d c=1 sm=1 tr=0 a=o7Djd4SkmPXITDn8qH+ssQ==:117 a=o7Djd4SkmPXITDn8qH+ssQ==:17 a=kj9zAlcOel0A:10 a=L24OOQBejmoA:10 a=XgFsyLpVmvDUC1GEQo8A:9 a=CjuIK1q_8ugA:10 Date: Wed, 23 Nov 2016 09:56:05 +0000 From: Nick Dyer To: Dmitry Torokhov Cc: Andrew Duggan , Chris Healy , Henrik Rydberg , Benjamin Tissoires , Linus Walleij , Bjorn Andersson , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 2/2] Input: synaptics-rmi4 - add support for F34 V7 bootloader Message-ID: <20161123095605.GB4833@lava.h.shmanahar.org> References: <1479668642-376-1-git-send-email-nick@shmanahar.org> <1479668642-376-3-git-send-email-nick@shmanahar.org> <20161123015111.GC21078@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161123015111.GC21078@dtor-ws> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1181 Lines: 34 On Tue, Nov 22, 2016 at 05:51:11PM -0800, Dmitry Torokhov wrote: > On Sun, Nov 20, 2016 at 07:04:02PM +0000, Nick Dyer wrote: > > + /* query 7 */ > > + unsigned char f34_query7_b0:1; > > + unsigned char has_bootloader:1; > > + unsigned char has_device_config:1; > > + unsigned char has_flash_config:1; > > + unsigned char has_manufacturing_block:1; > > + unsigned char has_guest_serialization:1; > > + unsigned char has_global_parameters:1; > > + unsigned char has_core_code:1; > > + unsigned char has_core_config:1; > > + unsigned char has_guest_code:1; > > + unsigned char has_display_config:1; > > + unsigned char f34_query7_b11__15:5; > > + unsigned char f34_query7_b16__23; > > + unsigned char f34_query7_b24__31; > > I see bitfields and I think this is not going to work on big endian > arches because unfortunately they "fill" the bytes with bits in opposite > order. > > We had to rework old Unixsphere code to get rid of bitfields for on-wire > data; this seems to be coming from that code base as well and so needs > to be reworked too. Hi Dmitry- Thanks - that makes sense. I will rework this bit to remove the bitfields. cheers Nick