Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935919AbcKWL0I (ORCPT ); Wed, 23 Nov 2016 06:26:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44454 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934939AbcKWL0F (ORCPT ); Wed, 23 Nov 2016 06:26:05 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20161123104757.GE24624@leverpostej> References: <20161123104757.GE24624@leverpostej> <147986054870.13790.8640536414645705863.stgit@warthog.procyon.org.uk> <147986057768.13790.3027173260868896792.stgit@warthog.procyon.org.uk> To: Mark Rutland Cc: dhowells@redhat.com, lukas@wunner.de, linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] efi: Get the secure boot status [ver #2] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <18006.1479900357.1@warthog.procyon.org.uk> Date: Wed, 23 Nov 2016 11:25:57 +0000 Message-ID: <18007.1479900357@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 23 Nov 2016 11:25:59 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 378 Lines: 14 Mark Rutland wrote: > int secure_boot = efi_get_secureboot(sys_table); > > if (secure_boot > 0) > pr_efi(sys_table, "UEFI Secure Boot is enabled.\n"); > if (secure_boot < 0) > pr_efi_err(sys_table, > "could not determine UEFI Secure Boot status.\n"); In which case, should this be moved into efi_get_secureboot() and it return a bool? David