Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935846AbcKWLrX (ORCPT ); Wed, 23 Nov 2016 06:47:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55098 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756385AbcKWLrV (ORCPT ); Wed, 23 Nov 2016 06:47:21 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20161123102747.GD24624@leverpostej> References: <20161123102747.GD24624@leverpostej> <147986054870.13790.8640536414645705863.stgit@warthog.procyon.org.uk> <147986056324.13790.12670822944798392730.stgit@warthog.procyon.org.uk> To: Mark Rutland Cc: dhowells@redhat.com, lukas@wunner.de, linux-efi@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime services [ver #2] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <6124.1479901598.1@warthog.procyon.org.uk> Date: Wed, 23 Nov 2016 11:46:38 +0000 Message-ID: <6125.1479901598@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 23 Nov 2016 11:46:41 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 961 Lines: 29 Mark Rutland wrote: > Any reason to not Cc LAKML? Probably not. > On Wed, Nov 23, 2016 at 12:22:43AM +0000, David Howells wrote: > > Provide the ability to perform mixed-mode runtime service calls for arm in > > the same way that commit 0a637ee61247bd4bed9b2a07568ef7a1cfc76187 > > ("x86/efi: Allow invocation of arbitrary boot services") provides the > > ability to invoke arbitrary boot services. > > I'm not sure I understand. On arm/arm64, "mixed-mode" simply isn't possible. > > I see we already call runtime services directly in efi_get_secureboot() > in drivers/firmware/efi/libstub/arm-stub.c. > > If this is just to provide a consistent API for the stub, please note > that. How about: arm/efi: Allow invocation of arbitrary runtime services efi_call_runtime() is provided for x86 to be able abstract mixed mode support. Provide this for ARM also so that common code work in mixed mode also. David