Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936166AbcKWLrg (ORCPT ); Wed, 23 Nov 2016 06:47:36 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:34402 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756402AbcKWLrV (ORCPT ); Wed, 23 Nov 2016 06:47:21 -0500 Subject: Re: [PATCH 2/5] power: supply: tps65217: Remove IRQ data from driver data To: Sebastian Reichel References: <20161115131855.4175-1-woogyom.kim@gmail.com> <20161115131855.4175-3-woogyom.kim@gmail.com> <20161122165107.nk2lm36nhz6wwlyp@earth> <20161122165829.kvpxzi6iddmr347b@earth> Cc: Enric Balletbo i Serra , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org From: Milo Kim Message-ID: Date: Wed, 23 Nov 2016 20:47:11 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161122165829.kvpxzi6iddmr347b@earth> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 653 Lines: 17 On 11/23/2016 01:58 AM, Sebastian Reichel wrote: > On Tue, Nov 22, 2016 at 05:51:07PM +0100, Sebastian Reichel wrote: >> > On Tue, Nov 15, 2016 at 10:18:52PM +0900, Milo Kim wrote: >>> > > IRQ number is only used on requesting the interrupt, so no need to keep >>> > > it inside the driver data. > Please move simple cleanup patches like this one to the > begin of the patch series. > >>> > > In case of polling, poll_task is valid only when polling thread is >>> > > activated. > And merge this change into the patch were you introduced the > problem... Thanks for your feedback. Let me regenerate the patch-set for better review. Best regards, Milo