Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935992AbcKWL7e convert rfc822-to-8bit (ORCPT ); Wed, 23 Nov 2016 06:59:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60970 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754330AbcKWL7c (ORCPT ); Wed, 23 Nov 2016 06:59:32 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <147986054870.13790.8640536414645705863.stgit@warthog.procyon.org.uk> <147986056324.13790.12670822944798392730.stgit@warthog.procyon.org.uk> <5320.1479893643@warthog.procyon.org.uk> To: Ard Biesheuvel Cc: dhowells@redhat.com, Lukas Wunner , "linux-efi@vger.kernel.org" , linux-security-module , keyrings@vger.kernel.org, "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/6] arm/efi: Allow invocation of arbitrary runtime services [ver #2] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <6257.1479901869.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Wed, 23 Nov 2016 11:51:09 +0000 Message-ID: <6258.1479901869@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 23 Nov 2016 11:51:11 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 618 Lines: 17 Ard Biesheuvel wrote: > > What I've changed the ARM and ARM64 things to is: > > > > #define efi_call_runtime(f, ...) ((efi_##f##_t *)sys_table_arg->runtime->f)(__VA_ARGS__) > > > > Could we please instead fix the definition of efi_runtime_services_t, > given that we have typedefs already for all its members? Okay, I've pulled in your patch and removed the cast. I would like to provide wrapper static inlines for things like efi_get_variable() to get the parameter checking, but the sys_table_arg behind-the-scenes parameter is tricky to deal with in that case. David