Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936459AbcKWM7B (ORCPT ); Wed, 23 Nov 2016 07:59:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54894 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935439AbcKWM66 (ORCPT ); Wed, 23 Nov 2016 07:58:58 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20161122061233.GA4762@light.dominikbrodowski.net> References: <20161122061233.GA4762@light.dominikbrodowski.net> <20161116222731.563fb85e@lxorguk.ukuu.org.uk> <147933283664.19316.12454053022687659937.stgit@warthog.procyon.org.uk> <26173.1479769852@warthog.procyon.org.uk> To: Dominik Brodowski Cc: dhowells@redhat.com, keyrings@vger.kernel.org, matthew.garrett@nebula.com, linux-security-module@vger.kernel.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, gnomes@lxorguk.ukuu.org.uk Subject: Re: [PATCH] Lock down drivers that can have io ports, io mem, irqs and dma changed MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <8341.1479905906.1@warthog.procyon.org.uk> Date: Wed, 23 Nov 2016 12:58:26 +0000 Message-ID: <8342.1479905906@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 23 Nov 2016 12:58:31 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 621 Lines: 18 Dominik Brodowski wrote: > You might also need to disable CIS overrides and CIS firmware loading for > PCMCIA drivers, I presume. That needs two changes: > > - Abort in drivers/pcmcia/ds.c::pcmcia_load_firmware() or disable > the CONFIG_PCMCIA_LOAD_CIS config option permanently. This really ought to be handled through signature checking in request_firmware(). > - Abort in drivers/pcmcia/cistpl.c::pccard_store_cis() or remove > write access to the "cis" file in > drivers/pcmcia/cistpl.c::pccard_cis_attr What is that doing? Allowing the device to be reconfigured? David