Subject: Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217
 interrupt sources
To: Arnd Bergmann <arnd@arndb.de>
References: <20161121131515.8040-1-woogyom.kim@gmail.com>
 <20161122155759.GG10134@dell.home>
 <bd4944d8-3cef-b3f7-4fba-6de590493047@gmail.com>
 <33562327.jVWx4tN2gP@wuerfel>
Cc: linux-arm-kernel@lists.infradead.org, Lee Jones <lee.jones@linaro.org>,
        devicetree@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
        linux-kernel@vger.kernel.org, bcousson@baylibre.com,
        linux-omap@vger.kernel.org, Robert Nelson <robertcnelson@gmail.com>
From: Milo Kim <woogyom.kim@gmail.com>
Message-ID: <27c48fc3-29bd-996b-bdc4-75884a39865a@gmail.com>
Date: Wed, 23 Nov 2016 22:06:18 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <33562327.jVWx4tN2gP@wuerfel>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 784
Lines: 23

On 11/23/2016 08:51 PM, Arnd Bergmann wrote:
> Ah, the numbers come from the data sheet. Please just remove the
> header then, there is no need to keep them as an ABI, in particular
> when the driver doesn't even include that header today.

Got it.

> What matters here is the binding documentation in
> Documentation/devicetree/bindings/power/supply/tps65217_charger.txt

OK, in addition to this, the interrupt specifier needs to be added in 
Documentation/devicetree/bindings/input/tps65218-pwrbutton.txt.

> Please fix that instead to mandate that the two interrupts are
> required, what their functions are, and what the interrupt-names
> (not interrupts-names) property must list.

Oops, wrong interrupt name property - my bad.

Thanks for all your feedback.

Best regards,
Milo