Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964845AbcKWNcY (ORCPT ); Wed, 23 Nov 2016 08:32:24 -0500 Received: from mail-qk0-f179.google.com ([209.85.220.179]:35063 "EHLO mail-qk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936078AbcKWNcV (ORCPT ); Wed, 23 Nov 2016 08:32:21 -0500 MIME-Version: 1.0 In-Reply-To: <20161122175539.3897-1-thierry.reding@gmail.com> References: <20161122173042.GA3239@ulmo.ba.sec> <20161122175539.3897-1-thierry.reding@gmail.com> From: Linus Walleij Date: Wed, 23 Nov 2016 14:30:45 +0100 Message-ID: Subject: Re: [PATCH] gpio: Add Tegra186 support To: Thierry Reding Cc: Stephen Warren , Suresh Mangipudi , Laxman Dewangan , Alexandre Courbot , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-tegra@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 928 Lines: 26 On Tue, Nov 22, 2016 at 6:55 PM, Thierry Reding wrote: > From: Thierry Reding > > Tegra186 has two GPIO controllers that are largely register compatible > between one another but are completely different from the controller > found on earlier generations. > > Signed-off-by: Thierry Reding I would prefer if you could try to convert this driver to use CONFIG_GPIOLIB_IRQCHIP and install a chained interrupt handler with gpiochip_irqchio_add() + gpiolib_set_chained_irqchip(). It would save us so much trouble and so much complicated code to maintain for this custom irqdomain. I suggest you to look into the mechanisms mentioned in my previous mail for how to poke holes in the single linear irqdomain used by this mechanism. As it seems, you only have one parent interrupt with all these IRQs cascading off it as far as I can tell. Yours, Linus Walleij