Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965406AbcKWQAs (ORCPT ); Wed, 23 Nov 2016 11:00:48 -0500 Received: from mga04.intel.com ([192.55.52.120]:58748 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S940585AbcKWQAq (ORCPT ); Wed, 23 Nov 2016 11:00:46 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,538,1473145200"; d="scan'208";a="904781632" Date: Wed, 23 Nov 2016 17:59:25 +0200 From: Jarkko Sakkinen To: Tomas Winkler Cc: tpmdd-devel@lists.sourceforge.net, Jason Gunthorpe , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] tpm: kdoc cleanup Message-ID: <20161123155925.v7moohcnil35afhq@intel.com> References: <1479895454-15076-1-git-send-email-tomas.winkler@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1479895454-15076-1-git-send-email-tomas.winkler@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 771 Lines: 24 On Wed, Nov 23, 2016 at 12:04:10PM +0200, Tomas Winkler wrote: > Cleanup tpm in-code documentation. > > Tomas Winkler (4): > tpm: add kdoc for tpm_transmit and tpm_transmit_cmd > tpm/tpm2-chip: fix kdoc errors > tmp: use pdev for parent device in tpm_chip_alloc > tpm/vtpm: fix kdoc warnings Thanks. Overally LGTM but I have to postpone the review till' next week. /Jarkko > > drivers/char/tpm/tpm-chip.c | 8 +-- > drivers/char/tpm/tpm-interface.c | 33 ++++++++++-- > drivers/char/tpm/tpm2-cmd.c | 105 +++++++++++++++++++++----------------- > drivers/char/tpm/tpm_ibmvtpm.c | 51 +++++++++--------- > drivers/char/tpm/tpm_vtpm_proxy.c | 48 ++++++++++++----- > 5 files changed, 150 insertions(+), 95 deletions(-) > > -- > 2.7.4 >