Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933745AbcKWUDd (ORCPT <rfc822;w@1wt.eu>);
        Wed, 23 Nov 2016 15:03:33 -0500
Received: from mail-io0-f173.google.com ([209.85.223.173]:33970 "EHLO
        mail-io0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750945AbcKWUDc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 23 Nov 2016 15:03:32 -0500
MIME-Version: 1.0
In-Reply-To: <20161123182115.GA28733@e106950-lin.cambridge.arm.com>
References: <20161116180156.GA21156@e106950-lin.cambridge.arm.com>
 <CANn89iK=yTkVKi9Wnx3ZXWZSOQc6KJT-FcE7H-5+QB85GE4=Vw@mail.gmail.com>
 <20161116210139.GB21156@e106950-lin.cambridge.arm.com> <CANn89iKu+=7eD3MenkpfiwqkerwKkJJXonzHi=yiKc3o0A3p9w@mail.gmail.com>
 <20161117164200.GA24653@e106950-lin.cambridge.arm.com> <alpine.DEB.2.20.1611180125400.3640@nanos>
 <20161122103351.GA25080@e106950-lin.cambridge.arm.com> <CANn89i+dBOafrP9TjJgPDifjycQvoPET6RUCuNXKu4tiJ_HJRQ@mail.gmail.com>
 <20161122152733.GH25080@e106950-lin.cambridge.arm.com> <CANn89iJiYaZKsfQ_MaEfFODBeoufhE8ZPQMSSjCwVhNkXTo-=Q@mail.gmail.com>
 <20161123182115.GA28733@e106950-lin.cambridge.arm.com>
From: Eric Dumazet <edumazet@google.com>
Date: Wed, 23 Nov 2016 12:03:28 -0800
Message-ID: <CANn89iJXeNFgmy8YgSSnuNrekev-FgoyJ1GqOdFgM48wfpbr5Q@mail.gmail.com>
Subject: Re: Regression: Failed boots bisected to 4cd13c21b207 "softirq: Let
 ksoftirqd do its job"
To: Brian Starkey <brian.starkey@arm.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Alexander Potapenko <glider@google.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 835
Lines: 30

On Wed, Nov 23, 2016 at 10:21 AM, Brian Starkey <brian.starkey@arm.com> wrote:

> This patch didn't help.
>
> I did get some new traces though - I've attached the diff for the
> trace_printks I added.
>
> Before 4cd13c21b207:
> https://drive.google.com/open?id=0B8siaK6ZjvEwcEtOeFQzTmY0Nnc
> After 4cd13c21b207:
> https://drive.google.com/open?id=0B8siaK6ZjvEwZnQ4MVg1d3d1Tm8
>
> It looks like the difference is that after 4cd13c21b207 the RX softirq
> isn't running, and RX interrupts don't call softirq_raise anymore -
> presumably because there's one pending, but I didn't have time to
> track that down to a code-path.
>
> Cheers,
> -Brian
>

Hi Brian

Looks like netif_rx() drops the incoming packets then ?

Maybe netif_running() is not happy :(

Could you trace netif_rx() return value (NET_RX_SUCCESS or NET_RX_DROP)

Thanks !