Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933548AbcKWVcr (ORCPT ); Wed, 23 Nov 2016 16:32:47 -0500 Received: from mail-qt0-f196.google.com ([209.85.216.196]:32783 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932758AbcKWVcp (ORCPT ); Wed, 23 Nov 2016 16:32:45 -0500 Date: Wed, 23 Nov 2016 16:32:43 -0500 From: Tejun Heo To: Shaohua Li Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Kernel-team@fb.com, axboe@fb.com, vgoyal@redhat.com Subject: Re: [PATCH V4 11/15] blk-throttle: add interface to configure think time threshold Message-ID: <20161123213243.GD11306@mtj.duckdns.org> References: <52aae27038728bf0fd1b2b3b6536fcc28c9f2e6c.1479161136.git.shli@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52aae27038728bf0fd1b2b3b6536fcc28c9f2e6c.1479161136.git.shli@fb.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1032 Lines: 33 On Mon, Nov 14, 2016 at 02:22:18PM -0800, Shaohua Li wrote: > Add interface to configure the threshold > > Signed-off-by: Shaohua Li > --- > block/blk-sysfs.c | 7 +++++++ > block/blk-throttle.c | 25 +++++++++++++++++++++++++ > block/blk.h | 4 ++++ > 3 files changed, 36 insertions(+) > > diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c > index 3e284e4..f15aeed 100644 > --- a/block/blk-sysfs.c > +++ b/block/blk-sysfs.c > @@ -532,6 +532,12 @@ static struct queue_sysfs_entry throtl_slice_entry = { > .show = blk_throtl_slice_show, > .store = blk_throtl_slice_store, > }; > + > +static struct queue_sysfs_entry throtl_idle_threshold_entry = { > + .attr = {.name = "throttling_idle_threshold", .mode = S_IRUGO | S_IWUSR }, > + .show = blk_throtl_idle_threshold_show, > + .store = blk_throtl_idle_threshold_store, > +}; Shouldn't this be a per-cgroup setting along with latency target? These two are the parameters which define how the cgroup should be treated time-wise. Thanks. -- tejun