Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934301AbcKWW6n (ORCPT ); Wed, 23 Nov 2016 17:58:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59794 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933330AbcKWW6m (ORCPT ); Wed, 23 Nov 2016 17:58:42 -0500 Date: Wed, 23 Nov 2016 23:58:37 +0100 From: Jiri Olsa To: kan.liang@intel.com Cc: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com, tglx@linutronix.de, namhyung@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com, wangnan0@huawei.com, mark.rutland@arm.com, andi@firstfloor.org Subject: Re: [PATCH 05/14] perf tools: handle PERF_RECORD_OVERHEAD record type Message-ID: <20161123225837.GF15978@krava> References: <1479894292-16277-1-git-send-email-kan.liang@intel.com> <1479894292-16277-6-git-send-email-kan.liang@intel.com> <20161123223559.GB15978@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161123223559.GB15978@krava> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 23 Nov 2016 22:58:42 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 667 Lines: 21 On Wed, Nov 23, 2016 at 11:35:59PM +0100, Jiri Olsa wrote: > On Wed, Nov 23, 2016 at 04:44:43AM -0500, kan.liang@intel.com wrote: > > SNIP > > > + > > static void dso__adjust_kmod_long_name(struct dso *dso, const char *filename) > > { > > const char *dup_filename; > > @@ -1536,6 +1542,8 @@ int machine__process_event(struct machine *machine, union perf_event *event, > > case PERF_RECORD_SWITCH: > > case PERF_RECORD_SWITCH_CPU_WIDE: > > ret = machine__process_switch_event(machine, event); break; > > + case PERF_RECORD_OVERHEAD: > > + ret = machine__process_overhead_event(machine, event); break; > > missing breaks ugh.. im blind.. sry :-\ jirka