Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935769AbcKXBAT (ORCPT ); Wed, 23 Nov 2016 20:00:19 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:46376 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935053AbcKXBAR (ORCPT ); Wed, 23 Nov 2016 20:00:17 -0500 Date: Wed, 23 Nov 2016 16:59:58 -0800 From: Shaohua Li To: Tejun Heo CC: , , , , Subject: Re: [PATCH V4 09/15] blk-throttle: make bandwidth change smooth Message-ID: <20161124005957.GA4724@ksenks-mbp.dhcp.thefacebook.com> References: <0e70ed3ab921ff6556cfe6a6c30428d4cfaf9e52.1479161136.git.shli@fb.com> <20161123212335.GC11306@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161123212335.GC11306@mtj.duckdns.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [2620:10d:c090:180::2e85] X-ClientProxiedBy: MWHPR20CA0023.namprd20.prod.outlook.com (10.171.151.161) To CY4PR15MB1639.namprd15.prod.outlook.com (10.175.120.23) X-MS-Office365-Filtering-Correlation-Id: e6910500-57ba-4044-5c06-08d414053c51 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY4PR15MB1639; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1639;3:BieWu4FbE/6shaK3kT1w8WdCn1aMNEY496JgqG+VEBmPAp8iiLW2gGwSJE9McYr4788X+CRP3kFloZKRtOh4zPFLCa5LPsYEcR9N3ZDFKBONBBXYKPArcdZYlEKaQD2QIQdyESwpbh0oWw4rY0HzDxIcmTfHtxNG86YhmiWZ0W+CQFIdpyLfsLGk1MVGxwMdTG3Q0cZNIEHFDwWr+p+JlwySrx6pfePQ0JJYLk7OszDiByO/oBJqZDVOvdk/qVKoaY+Ob/1keDZXrnf6r9UiTg== X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1639;25:MMJaSKHL+AXFk/XCFsdphGnDASz1Ci81r/hHqTWi6n0Y5Y8+6ggriCk1b9yw7xde26UI4+lg5rfNirKSjw28dEQkhlEVKV+fws45SE2nCk6PXBBuQ6rZFbQ17YrDZwvZ78thQVpzab8dTuTWSyaAxRPpbKQd5IFTHwVhGL7jnclnlc5yfvWs2XMUNmT7FTldilFEBAlOadudIDdbjg4hjTq3oxRKS8vBZ995D7SeE11ryavlXbSzclfJV81TYz1r/VFSon3fSSGI3cF1Q4kgQfe/UhF04Sz7jRCRobuu+oKl1m4QB+fuxn8K1xQNo/RtxU5t848flX8pXGZOzdtptZqMKPaMxyNDJr/fxa8NLeBq8va7NxWWZtdxKwZODdnVS5pykQclTHWAj95+nD634KHN78CcU4eU94slItpO0HTJAi/lXdE+3B+XWjn3aG6E0THoZSPAq8JpbemdbaWKbELYPLIX5FyWLdaE9QjxxmUMx3zR4+V0q7CVT8pgiNHgSzFZuGJz6ADETcLqlnA2viWVogLNWLfyLY0cbE77bREcK5e/UosJOhr5JbGI/bmcU2ejifD1Qa1vzMbXWSS1SVKfZyxlNXJkacoQUySVtjIDRsPUQxpYG+pyL+j/Y62L61HxQCZM2Im68WXTdMdRniu+RUY3Uw4/R/nzqx+h8CCj8HR16EKTKmfbygh2rvigPSjj2h9/5U2R0Wv9f2A+1vTnTEa/l+OgF7DsOHtLQNQ= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1639;31:Jt0LK4wH6d156CGDuZm2yc4DCcASoQtBH3KN6oQduToEQhfufb7OcryFRO5YUMG9meh2K6J3WnCPDzPnz5GWmbCk/S7LiOE/tB/SempROcC9D2JWEqi1srByk7s2L8Qhq2jhbhFnmT1F5IwPWKhC4N9VGsU/Xgp0nCOv3dvAhv+0b29krE24CTBLGA2AnODlGC/6L41mnWR5bq/pe093bDYnaSozDoHJsyi2WcorLARFh4G8zvABPD9t/p9G3DAf;20:M/PuT/up7pKpmOlYUkFnPO3Y4pqCT2FaMf/ESbaaMWlvzdYaF7oa7Mxcii4vVYTPGBV2c0vwB/ACr8wTBxRrVExNTUQhdYAGDJp4ArlksYfzIEedkzKND8RwG725QoqYERJDBE+SVmgF/v0r7RHHe21ii51vQNaV9Gm1aGrk3iaRPCgxhjtpsw6bPHL2Tqah3fLmb0jyOlNZgR63K0X77UWxjjCIROekjZIzAc3EU120BfMSxSBQTCZ0/Z7cuW/i X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040307)(6045199)(6060326)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(6061324)(6072148);SRVR:CY4PR15MB1639;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1639; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1639;4:N+4qW4Cx05E5KsoQM/7+W0sX9KrzHLPWkBCVmgw+AY9byZ2H0IkPkCwQXFFGg1+ayPNG48X1WyUiV6QZY38rl21TOvtsA23eOP2LN0UV/AChcqdk8tOZr202HDH/vJJgtKyivukIGtwu/pX5XfFnsIsizKSOrKJwhTSy4z7ahwKZdCWokIrkT3Ee1L+gEIKgpKvqgJNb1IdPCD0lyt9qyczVMHBJYREZiYrAcB0Aacf5Ef7K7FuAcwvnXr189Ltno6sg/A4durY2QyLBAZghwThiweRYUvI5Sc8ZAE19XNF6SMZ3kreBp8yNbllEc+6IWdJOnFZv3woh88jhHsnhcKE6pqqNbSzmm9lLEIBkvZ5ajXnaRgC7ghaFzZpdofBayLZ7CcTzXyo2/HVpLYMnIfgDqF5LKEWLvjeu5yDgjfhtzyUEzHshnFgNBGEAjZ2cVdItIb9Uwv3i/8QJR7rmhkGZrgAkjqs1Qv9HoGY6uMSSicvRWqs3W5Fgyo1JM+eq X-Forefront-PRVS: 0136C1DDA4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(24454002)(189002)(199003)(106356001)(6116002)(5660300001)(101416001)(1076002)(4326007)(86362001)(110136003)(105586002)(6916009)(23726003)(2950100002)(46406003)(33656002)(2906002)(6666003)(4001350100001)(92566002)(97736004)(77096005)(9686002)(47776003)(81156014)(68736007)(8676002)(81166006)(97756001)(54356999)(50986999)(42186005)(7736002)(76176999)(305945005)(189998001)(7846002)(229853002)(50466002)(83506001)(38730400001)(18370500001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1639;H:ksenks-mbp.dhcp.thefacebook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY4PR15MB1639;23:X0bmKpG3/FDew5oNMwxoceiNzxJj1MYwX4qWl8wug?= =?us-ascii?Q?rs6dAyfxFSxvfRNW3iJAzAHiYKar1VtySRDkFK5ZBvCrlP/3daC02vp/TC+A?= =?us-ascii?Q?jLAzH0cVZD1AEC5GFeboOGsz26hIq9P3krChdqGk5BByO4Kwnoz/EI6XMLxv?= =?us-ascii?Q?ShVYpzEDsoG+HKUI2WAJE4fHBuMjpKKi9HcoU0Jex85J7c2UQiWVqemvxmVQ?= =?us-ascii?Q?/gjnUiWGDvCSMk+n9/amTZkTjnun/P91KVA3syhBKuFluE3zBtQ2LAi5NZLa?= =?us-ascii?Q?TBNwdItBU1fnM7YXx8jDFfqqtuxJVG8pdddREA3KZPZwU1BapydMNIVtvIxq?= =?us-ascii?Q?/rqkGDNisQFsQkPbxCQyl6poKe5T+4Raq7CJNsGyb4rovTrH8rB1k8Doe6oe?= =?us-ascii?Q?ezV8UDqz9RhTX4f7qgTTwvj6rrE8LZJbzbpqvfLGagDAXHaQ4Vug72O27IBZ?= =?us-ascii?Q?kxJISoj0lbonOElBGGBzdugTbLjbaUHmfzrlnyMcisy5ej9Qym6kDWBOP73l?= =?us-ascii?Q?5uwoeFOZyRSbn+v3neFCt+K7qIDSVbNQLzmjscRkYs6FIknkiUSBymExepGc?= =?us-ascii?Q?Nu5DPi8lg4FBzX+DHSyZtmuun7/oXtVHaWzPo24si1+/yZ9/Iszn5Z+BpVsr?= =?us-ascii?Q?t06TqGE5JSFkPCZdNOdYyE1b00I1Jo5SBxr/f5dwlf6nzFW1wbAU6aiTwr5T?= =?us-ascii?Q?VMa6l3FFapQDBifM/188MjZOlYk3HwKYBAmCq9R9moUPyfU0UOMyWZ1B9OyK?= =?us-ascii?Q?yJEZhR9+qAEFxk9guu31HbhHANY4HmhFiLos6zQuo9j2CyiyOLTblrNG38qd?= =?us-ascii?Q?mdifZepIgcTzf+IBffEAANQlsarXHjMe6G/NhGHM/JmiJEZxxUeWMTADe8Rx?= =?us-ascii?Q?JomE2SnzoU3ZL2tmjqvUD6+rB0KrjuSZ5LIiQRJ4vVulwGGwczJcdkgkqKup?= =?us-ascii?Q?Uq59h30WzLufSFcHF6jgYndZH6B73bhXapnRL2jT3Y0qDF3vZwILqQEZrpfl?= =?us-ascii?Q?GRGgfMJtxbsy8iLfNYt9SLzEksk49dx/wrLU5XeSY7RCuibtBIqKFRO0OZ3S?= =?us-ascii?Q?UXLI0lafvavMsbTXxdu8MhHII/sp3ScQ6yf0WEhjsPtDeNnOFaEKbQamSJIb?= =?us-ascii?Q?itklFgm62I=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1639;6:9bhUKVJIZjShkcPRjNMKh1FpNC3bSvKbUebA0vYciDkh9D2rz8K7x/oBVd4gZau5+G39/hCO532DlUfRFQ1k3GWQWITLKdNzAmo078ITflz1TvR2YUj3Vm4i9YdmPO2Sakh9dk5s9Um8eEtWGWQSlcckgfDodkPh5uZSx0OdTB+fHinULL8mo9KIOxFMcFvewlG2/e5cSvP/qGNSqbIDCeRVT6pSlK89Ouo64GsLVmc1adXz5wjNd9h9p1MeeIDVcU0u86ww2XMjcgJnctjii/ed7Gu8ONsGsswS+4HT4ZOycV88wJ45ZQ5FSrdI6D5oNP3TunUpDONZHe1vKcDd3x6l1lRFfjdc64mNRDE9FjTa/KFSxyu80kCk95CVlwaR+3G59OausynRP6kXugld2SZFqPM3mDu4eXv9MmEFugx5brg2MjLaPv98LNQX2ey8GhQwHqtueVTHrySFfyV8dw==;5:pSJIKiEjh4SYnhnOKuPT1DR1s+jwpdr80wMzolpLjTvOeeZeBndCs7dj/0Z9Zu/LUTtkoQQ6/2Khnn706TflEHOF4UolyieKWKu7FaFMbV0iQM1SGQ05RQ7Zw+1QBlaGSD2V1ZHHMJsujO6yizC8mqaXk+BcoCiPs9GCdxmjAE0=;24:gN7drVKhepiEhW395eb51eb7hSdHoD5Tv0oC8nvCTsES7NH8wcdHzqoY3tBanXMfFJvgoCKoyuwUaJ7a93bmMrvxLMzZSiBhJOKhSliEeuA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1639;7:7BbbCxWuS43mRaEJBquXBErgtfba9P87auNEpauR44nDez1rX8UE0b8+6n9aK+PMthwisAeWKbj7DB8Ale1axG8p0SsLIJEc8gja5v5lbRgVdeHbpzsEpQnvMMqUaATaVFO/pbUDpBLGSciaqs53ZqqPhv5payVy6xGc+JGoyounsqSkY/sdC3uj9DjcIUtsXTnwkQ3Ex25v1vCvGaU6btKqGtrLy7vAopcVi44fmv8aOg7SKUWu7K9HPRER7obzajwR8AggBNQxCW75xiOOrPRtTk2fK7odNbQmXhvi2X0UN1OSSN2zRSF+TKeok33xhgBK3mxeQ7S0kAj4L7MhH0aVXfgmvOuPhb0T6eqBG0hCpjVgZ4PeLCjZRoAc7yF3ZlGD5lCORz2SFcgaczPhbCIyWs9wVqYBS/Yyxfk26K9gCd3fZkV9K1IcD/T/pKyHtZfqkrS0kc+xOaxhfNl8Jg==;20:0bpNrvrqTWbUzpJNt3oGOaWYimFq//60nApnxHRd3v7AQUw7eiVOKB0HUWU+asqR+ZAdxXuw79zkwWWfX5eepdzclCPVgmmGGqomIiBNJxwupcYHU40StD0GhLzDQ3RYiQDKqC1vVsrFU4JnI/wJ+9wZwDegd5pVs3vYYCLhydI= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2016 01:00:07.9504 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1639 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-23_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 645 Lines: 17 On Wed, Nov 23, 2016 at 04:23:35PM -0500, Tejun Heo wrote: > Hello, > > On Mon, Nov 14, 2016 at 02:22:16PM -0800, Shaohua Li wrote: > > cg1/cg2 bps: 10/80 -> 15/105 -> 20/100 -> 25/95 -> 30/90 -> 35/85 -> 40/80 > > -> 45/75 -> 10/80 > > I wonder whether it'd make sense to make the clamping down gradual too > (way faster than the ramping up but still gradual). The control model > isn't immediate anyway and doing the other direction gradually too > might not hurt the overall control accuracy all that much. Sure, that's in my todo list. Part of the reason is I didn't figure out an easy to do it. I'll keep trying later. Thanks, Shaohua