Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754726AbcKXCYg (ORCPT ); Wed, 23 Nov 2016 21:24:36 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33738 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752634AbcKXCYf (ORCPT ); Wed, 23 Nov 2016 21:24:35 -0500 Date: Wed, 23 Nov 2016 18:24:28 -0800 From: Alexei Starovoitov To: Michael Holzheu Cc: Heiko Carstens , Martin Schwidefsky , Zvonko Kosic , linux-kernel@vger.kernel.org, Daniel Borkmann Subject: Re: [PATCH] bpf/samples: Fix PT_REGS_IP on s390x and use it Message-ID: <20161124022427.GA54828@ast-mbp.thefacebook.com> References: <20161123162839.3f355b92@TP-holzheu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161123162839.3f355b92@TP-holzheu> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 587 Lines: 16 On Wed, Nov 23, 2016 at 04:28:39PM +0100, Michael Holzheu wrote: > The files "sampleip_kern.c" and "trace_event_kern.c" directly access > "ctx->regs.ip" which is not available on s390x. Fix this and use the > PT_REGS_IP() macro instead. > > Besides of that also fix the macro for s390x and use psw.addr from pt_regs. > > Reported-by: Zvonko Kosic > Signed-off-by: Michael Holzheu Looks good. Acked-by: Alexei Starovoitov Please resubmit it to net-next and cc Dave. note that my @plumgrid email no longer vaid.