Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756641AbcKXEvY (ORCPT ); Wed, 23 Nov 2016 23:51:24 -0500 Received: from mail-wj0-f193.google.com ([209.85.210.193]:34301 "EHLO mail-wj0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753319AbcKXEvX (ORCPT ); Wed, 23 Nov 2016 23:51:23 -0500 Date: Thu, 24 Nov 2016 05:51:18 +0100 From: Ingo Molnar To: Viresh Kumar Cc: Rafael Wysocki , Ingo Molnar , Peter Zijlstra , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , Juri Lelli , Robin Randhawa , Steve Muckle Subject: Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task Message-ID: <20161124045118.GA18417@gmail.com> References: <09f8fe694b4491bfd20272e8c7dc0f13f35eb34e.1479197311.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09f8fe694b4491bfd20272e8c7dc0f13f35eb34e.1479197311.git.viresh.kumar@linaro.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1013 Lines: 35 * Viresh Kumar wrote: > + /* > + * For Real Time and Deadline tasks, schedutil governor shoots the > + * frequency to maximum. And special care must be taken to ensure that > + * this kthread doesn't result in that. > + * > + * This is (mostly) guaranteed by the work_in_progress flag. The flag is > + * updated only at the end of the sugov_work() and before that schedutil > + * rejects all other frequency scaling requests. > + * > + * Though there is a very rare case where the RT thread yields right > + * after the work_in_progress flag is cleared. The effects of that are > + * neglected for now. > + */ s/schedutil governor/ the schedutil governor s/And special care must be taken/ Special care must be taken s/at the end of the sugov_work()/ at the end of the sugov_work() function s/before that schedutil rejects/ before the schedutil governor rejects s/Though there is a very rare case where There is a very rare case though, where Thanks, Ingo