Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751414AbcKXFKu (ORCPT <rfc822;w@1wt.eu>);
        Thu, 24 Nov 2016 00:10:50 -0500
Received: from mail-pg0-f52.google.com ([74.125.83.52]:36241 "EHLO
        mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750858AbcKXFKs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Nov 2016 00:10:48 -0500
Date: Thu, 24 Nov 2016 10:40:34 +0530
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>, linaro-kernel@lists.linaro.org,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Juri Lelli <Juri.Lelli@arm.com>,
        Robin Randhawa <robin.randhawa@arm.com>,
        Steve Muckle <smuckle.linux@gmail.com>
Subject: Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue
 to SCHED_FIFO task
Message-ID: <20161124051034.GE9376@vireshk-i7>
References: <cover.1479197311.git.viresh.kumar@linaro.org>
 <09f8fe694b4491bfd20272e8c7dc0f13f35eb34e.1479197311.git.viresh.kumar@linaro.org>
 <20161124045118.GA18417@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161124045118.GA18417@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1147
Lines: 37

On 24-11-16, 05:51, Ingo Molnar wrote:
> 
> * Viresh Kumar <viresh.kumar@linaro.org> wrote:
> 
> > +	/*
> > +	 * For Real Time and Deadline tasks, schedutil governor shoots the
> > +	 * frequency to maximum. And special care must be taken to ensure that
> > +	 * this kthread doesn't result in that.
> > +	 *
> > +	 * This is (mostly) guaranteed by the work_in_progress flag. The flag is
> > +	 * updated only at the end of the sugov_work() and before that schedutil
> > +	 * rejects all other frequency scaling requests.
> > +	 *
> > +	 * Though there is a very rare case where the RT thread yields right
> > +	 * after the work_in_progress flag is cleared. The effects of that are
> > +	 * neglected for now.
> > +	 */
> 
> s/schedutil governor/
>   the schedutil governor
> 
> s/And special care must be taken/
>   Special care must be taken
> 
> s/at the end of the sugov_work()/
>   at the end of the sugov_work() function
> 
> s/before that schedutil rejects/
>   before the schedutil governor rejects
> 
> s/Though there is a very rare case where
>   There is a very rare case though, where

Thanks. I will send a fix for this.

-- 
viresh