Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751694AbcKXFxW (ORCPT ); Thu, 24 Nov 2016 00:53:22 -0500 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:43722 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750727AbcKXFxU (ORCPT ); Thu, 24 Nov 2016 00:53:20 -0500 MIME-Version: 1.0 In-Reply-To: <20161123144532.3089ebfd@free-electrons.com> References: <20161123132749.11666-1-quentin.schulz@free-electrons.com> <20161123132749.11666-2-quentin.schulz@free-electrons.com> <20161123144532.3089ebfd@free-electrons.com> From: Chen-Yu Tsai Date: Thu, 24 Nov 2016 13:52:55 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] gpio: axp209: use correct register for GPIO input status To: Thomas Petazzoni Cc: Quentin Schulz , Linus Walleij , Alexandre Courbot , Rob Herring , Mark Rutland , Chen-Yu Tsai , "linux-gpio@vger.kernel.org" , devicetree , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 787 Lines: 26 On Wed, Nov 23, 2016 at 9:45 PM, Thomas Petazzoni wrote: > Hello, > > On Wed, 23 Nov 2016 14:27:48 +0100, Quentin Schulz wrote: >> The GPIO input status was read from control register >> (AXP20X_GPIO[210]_CTRL) instead of status register (AXP20X_GPIO20_SS). >> >> Signed-off-by: Quentin Schulz > > This smells like a bug fix, so perhaps Cc: stable? Presently there are no in-tree boards that use the GPIOs as input. And the only user I see is the CHIP, for the headphone jack detection. Again, not supported in mainline yet. Not sure if there is value in sending it for stable. ChenYu > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com