Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756702AbcKXGMJ (ORCPT ); Thu, 24 Nov 2016 01:12:09 -0500 Received: from mail-pf0-f175.google.com ([209.85.192.175]:36619 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753817AbcKXGMI (ORCPT ); Thu, 24 Nov 2016 01:12:08 -0500 Date: Thu, 24 Nov 2016 11:42:03 +0530 From: Viresh Kumar To: Ingo Molnar Cc: Rafael Wysocki , Ingo Molnar , Peter Zijlstra , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot , Juri Lelli , Robin Randhawa , Steve Muckle Subject: Re: [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only used in slow path Message-ID: <20161124061203.GF9376@vireshk-i7> References: <20161124045337.GB18417@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161124045337.GB18417@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 903 Lines: 25 On 24-11-16, 05:53, Ingo Molnar wrote: > > Firstly, please start changes to scheduler code with a verb. This title: > > Subject: Re: [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only used in slow path > > is totally inadequate as it's a statement that says nothing about the _change_. > > What does the patch do? Does it add, remove, modify, fix or clean up? Thanks for the tip. I have sometimes seen similar subjects-line in patches from core developers and so thought it might be right. But yes I understand what you are saying and will take care of this in future across all subsystems. > * Viresh Kumar wrote: > > > Execute the irq-work specific initialization/exit code only when the > > fast path isn't available. > > Is this an optimization? A correctness fix? Its an optimization but yeah I will try to explain a bit more next time. -- viresh