Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756484AbcKXHad (ORCPT ); Thu, 24 Nov 2016 02:30:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60404 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755116AbcKXHac (ORCPT ); Thu, 24 Nov 2016 02:30:32 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <147986254484.19139.8038609825799670925.stgit@warthog.procyon.org.uk> <147986255194.19139.9583434946564699577.stgit@warthog.procyon.org.uk> To: Andreas Dilger Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <6824.1479972453.1@warthog.procyon.org.uk> Date: Thu, 24 Nov 2016 07:27:33 +0000 Message-ID: <6825.1479972453@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 24 Nov 2016 07:27:35 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 650 Lines: 17 Andreas Dilger wrote: > > + case S_IFCHR: printf(" character special file\n"); ft = 'c'; break; > > This will overflow 80 columns. Could use just "character special"? > > > + case S_IFDIR: printf(" directory\n"); ft = 'd'; break; > > + case S_IFBLK: printf(" block special file\n"); ft = 'b'; break; > > + case S_IFREG: printf(" regular file\n"); ft = '-'; break; > > + case S_IFLNK: printf(" symbolic link\n"); ft = 'l'; break; > > Having these all as single-word items would make it easier to parse for > test programs. Same with "IO Block:" -> "Blocksize:". Not a huge deal. Try doing "stat /dev/null". David