Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756919AbcKXIEW (ORCPT ); Thu, 24 Nov 2016 03:04:22 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:36910 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756832AbcKXIET (ORCPT ); Thu, 24 Nov 2016 03:04:19 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 8866961443 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH v4] drm: bridge: add DesignWare HDMI I2S audio support To: Kuninori Morimoto References: <8737j2bxba.wl%kuninori.morimoto.gx@renesas.com> <20161108111009.GO1041@n2100.armlinux.org.uk> <87oa1pscne.wl%kuninori.morimoto.gx@renesas.com> <87vavdcvgh.wl%kuninori.morimoto.gx@renesas.com> Cc: Russell King - ARM Linux , Mark Brown , David Airlie , Fabio Estevam , Daniel Vetter , Koji Matsuoka , Thierry Reding , Linux-ALSA , Liam Girdwood , Simon , linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jose Abreu From: Archit Taneja Message-ID: <626df165-da09-298e-ed60-03d4119caec2@codeaurora.org> Date: Thu, 24 Nov 2016 13:34:03 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87vavdcvgh.wl%kuninori.morimoto.gx@renesas.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1404 Lines: 50 Hi, On 11/24/2016 10:43 AM, Kuninori Morimoto wrote: > > Hi Archit, David, and DRM ML > > I had heared that Archit is the maintainer of dw-hdmi driver, but am I wrong ?? > I'm posting this patch series since half year ago, but no response > from him, and nothing happen (I got review from Russell though). > Is Archit really maintainer ?? > OTOH, get_maintainer.pl indicates David is the maintainer ? > What should I do for this patch ?? I'm not the maintainer of the dw-hdmi driver, but I pull in the changes that go into drm/bridge/ Will pull this. Thanks, Archit > >> Hi Russell >> >>>> @@ -11,4 +11,11 @@ struct dw_hdmi_audio_data { >>>> u8 *eld; >>>> }; >>>> >>>> +struct dw_hdmi_i2s_audio_data { >>>> + struct dw_hdmi *hdmi; >>>> + >>>> + void (*write)(struct dw_hdmi *hdmi, u8 val, int offset); >>>> + u8 (*read)(struct dw_hdmi *hdmi, int offset); >>>> +}; >>> >>> Another slight concern here is why we need this separate data for i2s - >>> maybe adding the write/read ops to struct dw_hdmi_audio_data would be >>> a better thing to do, which would then allow the AHB audio to drop >>> the .base argument in the future. >>> >>> I'm not that bothered about this though. So... >> >> Thank you for your feedback. >> Maybe we can merge these in incremental patch if needed ? >> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project