Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757042AbcKXIOU (ORCPT ); Thu, 24 Nov 2016 03:14:20 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:32884 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756715AbcKXIN5 (ORCPT ); Thu, 24 Nov 2016 03:13:57 -0500 Subject: Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3] To: Andreas Dilger References: <147986254484.19139.8038609825799670925.stgit@warthog.procyon.org.uk> <147986255194.19139.9583434946564699577.stgit@warthog.procyon.org.uk> <768343b5-e9b4-a86c-53de-2929bc290342@gmail.com> <19284F6D-73B9-4A1A-8227-2B2B87F29FE9@dilger.ca> Cc: mtk.manpages@gmail.com, David Howells , linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org From: "Michael Kerrisk (man-pages)" Message-ID: <5a4327bd-06ef-d24e-cc87-715bc2de6f62@gmail.com> Date: Thu, 24 Nov 2016 09:13:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <19284F6D-73B9-4A1A-8227-2B2B87F29FE9@dilger.ca> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1275 Lines: 43 Hi Andreas, On 11/23/2016 11:57 PM, Andreas Dilger wrote: > On Nov 23, 2016, at 1:37 AM, Michael Kerrisk wrote: >> [...] >>> =============== >>> NEW SYSTEM CALL >>> =============== >>> >>> The new system call is: >>> >>> int ret = statx(int dfd, >>> const char *filename, >>> unsigned int flags, >> >> In the 0/4 of this patch series, this argument is called 'atflags'. >> These should be consistent. 'flags' seems correct to me. > > Given that there are a number of different flags and masks in use for > this syscall, naming this field "atflags" makes it more clear what it > is used for. Well, yes, but in all of the "at" calls the argument is just flags. So, better to be consistent in that dimension, I'd say, and then make sure we perhaps have meaningfil names for the fiellds, as you suggest next: >>> unsigned int mask, > > Similarly, naming this field "request_mask" would also be more clear, > and matches what is used elsewhere in the code. > > That said, I don't care enough about this detail to request a patch refresh, > but it would be useful for the man pages. -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/