Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938567AbcKXJaO (ORCPT ); Thu, 24 Nov 2016 04:30:14 -0500 Received: from mail-lf0-f47.google.com ([209.85.215.47]:33946 "EHLO mail-lf0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938478AbcKXJaL (ORCPT ); Thu, 24 Nov 2016 04:30:11 -0500 Subject: Re: [PATCH] usb: xhci: Remove unuseful 'return' statement To: Baolin Wang , mathias.nyman@intel.com, gregkh@linuxfoundation.org References: <68e3188e71377820649c0c484958b3af2df722d6.1479975110.git.baolin.wang@linaro.org> Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, broonie@kernel.org From: Sergei Shtylyov Message-ID: <50f53faa-f719-0dd1-7cf3-6ed0938a1e5f@cogentembedded.com> Date: Thu, 24 Nov 2016 12:30:04 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <68e3188e71377820649c0c484958b3af2df722d6.1479975110.git.baolin.wang@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 736 Lines: 25 Hello. On 11/24/2016 11:13 AM, Baolin Wang wrote: > Since these 'return' statements are not generally useful in void function, > remove them. > > Signed-off-by: Baolin Wang [...] > diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c > index 48a26d378..d6f59a3 100644 > --- a/drivers/usb/host/xhci-mem.c > +++ b/drivers/usb/host/xhci-mem.c > @@ -1146,7 +1146,6 @@ int xhci_setup_addressable_virt_dev(struct xhci_hcd *xhci, struct usb_device *ud > case USB_SPEED_WIRELESS: > xhci_dbg(xhci, "FIXME xHCI doesn't support wireless speeds\n"); > return -EINVAL; > - break; Here you're removing *break* instead but not mentioning this in the patch description... [...] MBR, Sergei