Subject: Re: [PATCH v5 1/3] tpm: move event log init functions to
 tpm_eventlog_init.c
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
References: <1479922057-8752-1-git-send-email-nayna@linux.vnet.ibm.com>
 <1479922057-8752-2-git-send-email-nayna@linux.vnet.ibm.com>
 <20161123193830.GB13927@obsidianresearch.com>
Cc: tpmdd-devel@lists.sourceforge.net, peterhuewe@gmx.de,
        tpmdd@selhorst.net, jarkko.sakkinen@linux.intel.com,
        linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org
From: Nayna <nayna@linux.vnet.ibm.com>
Date: Thu, 24 Nov 2016 13:31:03 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <20161123193830.GB13927@obsidianresearch.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Message-Id: <58369E3F.40509@linux.vnet.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 803
Lines: 27


On 11/24/2016 01:08 AM, Jason Gunthorpe wrote:
> On Wed, Nov 23, 2016 at 12:27:35PM -0500, Nayna Jain wrote:
>> The device driver code for the event log has the init functions and
>> TPM 1.2 parsing logic both defined in same file(tpm_eventlog.c).
>>
>> Since the initialization functions are common with the TPM 2.0 event
>> log support, this patch splits tpm_eventlog.c to have only TPM 1.2
>> event log parsing logic and moves the init functions into
>> tpm_eventlog_init.c.
>
> I think I'd rather see a tpm_eventlog1.c/tpm_eventlog2.c than this
> _init thing..

Do you mean tpm_eventlog1.c for TPM 1.2 and tpm_eventlog2.c for TPM 2.0 
  event log specific parsing ?

And if so, then which one should have the common functions for TPM 1.2 
and TPM 2.0 ?

Thanks & Regards,
    - Nayna

>
> Jason
>