Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938655AbcKXKhB (ORCPT ); Thu, 24 Nov 2016 05:37:01 -0500 Received: from mail-lf0-f46.google.com ([209.85.215.46]:33579 "EHLO mail-lf0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937846AbcKXKg7 (ORCPT ); Thu, 24 Nov 2016 05:36:59 -0500 Subject: Re: [PATCH] igb: Explicitly select page 0 at initialization To: "Matwey V. Kornilov" , jeffrey.t.kirsher@intel.com References: <1479983568-4383-1-git-send-email-matwey@sai.msu.ru> Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, todd.fujinaka@intel.com, carolyn.wyborny@intel.com, dchang@suse.com, jcheung@suse.com, matwey.kornilov@gmail.com, stable@vger.kernel.org From: Sergei Shtylyov Message-ID: Date: Thu, 24 Nov 2016 13:36:55 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <1479983568-4383-1-git-send-email-matwey@sai.msu.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1320 Lines: 35 Hello. On 11/24/2016 1:32 PM, Matwey V. Kornilov wrote: > The functions igb_read_phy_reg_gs40g/igb_write_phy_reg_gs40g (which were > removed in 2a3cdea) explicitly selected the required page at every phy_reg This is not the way to cite a commit -- you need to specify at least 12 digits and follow them with the commit subject enclosed into (""). > access. Currently, igb_get_phy_id_82575 relays on the fact that page 0 is > already selected. The assumption is not fulfilled for my Lex 3I380CW > motherboard with integrated dual i211 based gigabit ethernet. This leads to igb > initialization failure and network interfaces are not working: > > igb: Intel(R) Gigabit Ethernet Network Driver - version 5.4.0-k > igb: Copyright (c) 2007-2014 Intel Corporation. > igb: probe of 0000:01:00.0 failed with error -2 > igb: probe of 0000:02:00.0 failed with error -2 > > In order to fix it, we explicitly select page 0 before first access to phy > registers. > > See also: https://bugzilla.suse.com/show_bug.cgi?id=1009911 > See also: http://www.lex.com.tw/products/pdf/3I380A&3I380CW.pdf > > Fixes: 2a3cdea ("igb: Remove GS40G specific defines/functions") Again, at least 12 digits. > Cc: # 4.5+ > Signed-off-by: Matwey V. Kornilov [...] MBR, Sergei