Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938670AbcKXKvG (ORCPT ); Thu, 24 Nov 2016 05:51:06 -0500 Received: from mail-yw0-f178.google.com ([209.85.161.178]:36711 "EHLO mail-yw0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935138AbcKXKvE (ORCPT ); Thu, 24 Nov 2016 05:51:04 -0500 MIME-Version: 1.0 In-Reply-To: <50f53faa-f719-0dd1-7cf3-6ed0938a1e5f@cogentembedded.com> References: <68e3188e71377820649c0c484958b3af2df722d6.1479975110.git.baolin.wang@linaro.org> <50f53faa-f719-0dd1-7cf3-6ed0938a1e5f@cogentembedded.com> From: Baolin Wang Date: Thu, 24 Nov 2016 18:50:16 +0800 Message-ID: Subject: Re: [PATCH] usb: xhci: Remove unuseful 'return' statement To: Sergei Shtylyov Cc: mathias.nyman@intel.com, Greg KH , USB , LKML , Mark Brown Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 987 Lines: 36 Hi, On 24 November 2016 at 17:30, Sergei Shtylyov wrote: > Hello. > > On 11/24/2016 11:13 AM, Baolin Wang wrote: > >> Since these 'return' statements are not generally useful in void function, >> remove them. >> >> Signed-off-by: Baolin Wang > > [...] >> >> diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c >> index 48a26d378..d6f59a3 100644 >> --- a/drivers/usb/host/xhci-mem.c >> +++ b/drivers/usb/host/xhci-mem.c >> @@ -1146,7 +1146,6 @@ int xhci_setup_addressable_virt_dev(struct xhci_hcd >> *xhci, struct usb_device *ud >> case USB_SPEED_WIRELESS: >> xhci_dbg(xhci, "FIXME xHCI doesn't support wireless >> speeds\n"); >> return -EINVAL; >> - break; > > > Here you're removing *break* instead but not mentioning this in the patch > description... OK. I will add description to explain it in new patch. Thanks. -- Baolin.wang Best Regards