Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938767AbcKXKvX (ORCPT ); Thu, 24 Nov 2016 05:51:23 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:36040 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935138AbcKXKvW (ORCPT ); Thu, 24 Nov 2016 05:51:22 -0500 From: Axel Haslam To: gregkh@linuxfoundation.org, nsekhar@ti.com, khilman@baylibre.com, david@lechnology.com, ptitiano@baylibre.com Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Axel Haslam Subject: [PATCHv2] USB: ohci: da8xx: Resume the entire host controller Date: Thu, 24 Nov 2016 11:50:56 +0100 Message-Id: <20161124105056.18257-1-ahaslam@baylibre.com> X-Mailer: git-send-email 2.9.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1042 Lines: 36 The da8xx ohci controller is not working after suspend and resume. This is because only the root hub is being resumed. Balance the ohci_suspend of the suspend path with an ohci_resume in the resume path so that we resume the entire controller, and not just the root hub. Also, while we are here, remove setting device power_state, as this is no longer needed and scheduled for removal Acked-by: Alan Stern Signed-off-by: Axel Haslam --- Changes v1->v2 * reword commit message (Alan Stern) drivers/usb/host/ohci-da8xx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/usb/host/ohci-da8xx.c b/drivers/usb/host/ohci-da8xx.c index 9e336f4..05da2cb 100644 --- a/drivers/usb/host/ohci-da8xx.c +++ b/drivers/usb/host/ohci-da8xx.c @@ -528,8 +528,7 @@ static int ohci_da8xx_resume(struct platform_device *dev) if (ret) return ret; - dev->dev.power.power_state = PMSG_ON; - usb_hcd_resume_root_hub(hcd); + ohci_resume(hcd, false); return 0; } -- 2.9.3