Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940711AbcKXK6T (ORCPT ); Thu, 24 Nov 2016 05:58:19 -0500 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:41876 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S937225AbcKXK6Q (ORCPT ); Thu, 24 Nov 2016 05:58:16 -0500 Subject: Re: [PATCH 7/10] mmc: sdhci-xenon: Add support to PHYs of Marvell Xenon SDHC To: Arnd Bergmann , Gregory CLEMENT References: <2204525.IWIYQVjIXl@wuerfel> CC: Ulf Hansson , Adrian Hunter , , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , , Thomas Petazzoni , , "Jack(SH) Zhu" , Jimmy Xu , Jisheng Zhang , Nadav Haklai , Ryan Gao , Doug Jones , Shiwu Zhang , Victor Gu , "Wei(SOCP) Liu" , Wilson Ding , Xueping Liu , Hilbert Zhang , Keji Zhang , Liuliu Zhao , Peng Zhu , Yu Cao , Romain Perier , Yehuda Yitschak , Marcin Wojtas , Hanna Hawa , Kostya Porotchkin , From: Ziji Hu Message-ID: Date: Thu, 24 Nov 2016 18:57:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <2204525.IWIYQVjIXl@wuerfel> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-24_04:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611240193 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1139 Lines: 34 Hi Arnd, On 2016/11/24 17:56, Arnd Bergmann wrote: > On Monday, October 31, 2016 12:09:56 PM CET Gregory CLEMENT wrote: >> From: Ziji Hu >> >> Marvell Xenon eMMC/SD/SDIO Host Controller contains PHY. >> Three types of PHYs are supported. >> >> Add support to multiple types of PHYs init and configuration. >> Add register definitions of PHYs. >> >> Signed-off-by: Hu Ziji >> Signed-off-by: Gregory CLEMENT >> > > Please explain in the changelog why this is not a generic > phy driver (or three of them). > Actually we tried to put the PHY code into Linux PHY framework. But it cannot fit in Linux common PHY framework. Our Xenon SDHC PHY register is a part of Xenon SDHC register set. Besides, during MMC initialization, MMC sequence has to call several PHY functions to complete timing setting. In those PHY setting functions, they have to access SDHC register and know current MMC setting, such as bus width, clock frequency and speed mode. As a result, we have to implement PHY under MMC directory. Thank you. Best regards, Hu Ziji > Arnd >