Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965406AbcKXLm3 (ORCPT ); Thu, 24 Nov 2016 06:42:29 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:49132 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965215AbcKXLm2 (ORCPT ); Thu, 24 Nov 2016 06:42:28 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 6894160CE3 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Adam Borowski Cc: Philip Muller , linux-kernel@vger.kernel.org, Nicholas Piggin , Greg Kroah-Hartman , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Thorsten Leemhuis Subject: Regression: Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm References: <20161123205338.GA12050@angband.pl> <20161123210256.31501-1-kilobyte@angband.pl> Date: Thu, 24 Nov 2016 13:42:22 +0200 In-Reply-To: <20161123210256.31501-1-kilobyte@angband.pl> (Adam Borowski's message of "Wed, 23 Nov 2016 22:02:56 +0100") Message-ID: <871sy1nly9.fsf_-_@purkki.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1332 Lines: 31 (Adding Thorsten because this is a serious regression and still not fixed) Adam Borowski writes: > Commit 4efca4ed ("kbuild: modversions for EXPORT_SYMBOL() for asm") adds > modversion support for symbols exported from asm files. Architectures > must include C-style declarations for those symbols in asm/asm-prototypes.h > in order for them to be versioned. > > Add these declarations for x86, and an architecture-independent file that > can be used for common symbols. > > User impact: kernels may fail to load modules at all when > CONFIG_MODVERSIONS=y. > > Signed-off-by: Adam Borowski > Tested-by: Kalle Valo > Acked-by: Nicholas Piggin > Tested-by: Peter Wu > Tested-by: Oliver Hartkopp Calling it "may fail" is an understatement, for me _every_ 4.9-rc build I have tried on my x86 32 bit test laptop has had broken module loading and hence unable to boot. PLEASE fix this in Linus tree before he releases 4.9, either applying this patch (which I currently apply separately everytime I upgrade the kernel) or reverting the offending commit which started the whole mess. It's not cool to keep the build broken for this long, people have wasted lots of time because of this. -- Kalle Valo