Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: [PATCH 1/9] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device
From: Alexander Kochetkov <al.kochet@gmail.com>
In-Reply-To: <47746094.VbGlCfGZW0@diego>
Date: Thu, 24 Nov 2016 15:12:15 +0300
Cc: daniel.lezcano@linaro.org, tglx@linutronix.de,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org
Message-Id: <2217A50B-A694-4304-9628-23C4541FED5A@gmail.com>
References: <1479922177-20136-1-git-send-email-al.kochet@gmail.com> <47746094.VbGlCfGZW0@diego>
To: =?utf-8?Q?Heiko_St=C3=BCbner?= <heiko@sntech.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1235
Lines: 36

Hello Heiko,

> I haven't looked to deep into your patches yet, but what is missing is the 
> general goal of your whole series.


I will be very grateful to receive feedback

> 24 нояб. 2016 г., в 15:01, Heiko Stübner <heiko@sntech.de> написал(а):
> 
> git format-patch has this nice "--cover-letter" option that creates obviously 
> a cover-letter where you can describe what your series wants to achieve.
> 
I’ve used --cover-letter option but forget to add message text. Just subject.
So all patches was sent without cover letter. I’ll be careful next time.

> For those reading along, I guess what you want to achieve should be what I 
> describe below, so of course no need to resend just for this :-)
> 
> -----
> The clock supplying the arm-global-timer on the rk3188 is coming from the
> the cpu clock itself and thus changes its rate everytime cpufreq adjusts the 
> cpu frequency making this timer unsuitable as a stable clocksource.
> 
> The rk3188, rk3288 and following socs share a separate timer block already 
> handled by the rockchip-timer driver. Therefore adapt this driver to also be 
> able to act as clocksource on rk3188.
> -----
> 
> Right?

Yes, exactly as you wrote.

Regards,
Alexander.