Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965586AbcKXNvB (ORCPT ); Thu, 24 Nov 2016 08:51:01 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:40599 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964995AbcKXNvA (ORCPT ); Thu, 24 Nov 2016 08:51:00 -0500 Date: Thu, 24 Nov 2016 14:50:43 +0100 From: Peter Zijlstra To: "Liang, Kan" Cc: Jiri Olsa , "mingo@redhat.com" , "acme@kernel.org" , "linux-kernel@vger.kernel.org" , "alexander.shishkin@linux.intel.com" , "tglx@linutronix.de" , "namhyung@kernel.org" , "jolsa@kernel.org" , "Hunter, Adrian" , "wangnan0@huawei.com" , "mark.rutland@arm.com" , "andi@firstfloor.org" Subject: Re: [PATCH 01/14] perf/x86: Introduce PERF_RECORD_OVERHEAD Message-ID: <20161124135043.GF3092@twins.programming.kicks-ass.net> References: <1479894292-16277-1-git-send-email-kan.liang@intel.com> <1479894292-16277-2-git-send-email-kan.liang@intel.com> <20161123234122.GA19783@krava> <37D7C6CF3E00A74B8858931C1DB2F07750CA2BC9@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F07750CA2BC9@SHSMSX103.ccr.corp.intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 427 Lines: 14 On Thu, Nov 24, 2016 at 01:45:28PM +0000, Liang, Kan wrote: > > I think we should make this optional/configurable like the rest of the aux > > events, like below.. > > > > The overhead logging only happens when event is going to be disabled or > the task is scheduling out. It should not be much and expensive. > > Peter, > > What do you think? > Should we make it configurable? Is there a downside to having it optional?