Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966643AbcKXPtL (ORCPT <rfc822;w@1wt.eu>);
        Thu, 24 Nov 2016 10:49:11 -0500
Received: from mail-wm0-f47.google.com ([74.125.82.47]:35043 "EHLO
        mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S966250AbcKXPsw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 24 Nov 2016 10:48:52 -0500
MIME-Version: 1.0
From: Sylvain Munaut <s.munaut@whatever-company.com>
Date: Thu, 24 Nov 2016 16:48:41 +0100
Message-ID: <CAF6-1L6+30LieDibYaspJtwKUwVGfQz4bp5de=YdxuD=Bkw8eg@mail.gmail.com>
Subject: Regarding "scsi_lib: Decode T10 vendor IDs" d230823a1c4c3e97afd4c934b86b3975d5e20249
To: LKML <linux-kernel@vger.kernel.org>
Cc: Paul Mackerras <paulus@ozlabs.org>, Hannes Reinecke <hare@suse.com>,
        Bart Van Assche <bart.vanassche@sandisk.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 651
Lines: 24

Hi,


Regarding this commit :

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=d230823a1c4c3e97afd4c934b86b3975d5e20249

Looking at both the code and the comment, it seems to me you wanted
'T10' id to be a last resort if nothing else was available.

If that was the intent, it's not working ...

I have a Samsung 850 Pro SSD that has the NAA identifier after the T10
one in the vpd_pg83 and so it's returning the T10 now because it's
longer.

Did I misunderstand the intent ? Or is it a bug ? (for the latter, I
can write a patch myself, I just didn't want to loose my time if I
misunderstood).


Cheers,

   Sylvain Munaut