Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757313AbcKXQ1G (ORCPT ); Thu, 24 Nov 2016 11:27:06 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:34188 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756487AbcKXQ1D (ORCPT ); Thu, 24 Nov 2016 11:27:03 -0500 Date: Thu, 24 Nov 2016 11:19:07 -0500 (EST) Message-Id: <20161124.111907.890044153075333621.davem@davemloft.net> To: mlord@pobox.com Cc: hayeswang@realtek.com, netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH net 1/2] r8152: fix the sw rx checksum is unavailable From: David Miller In-Reply-To: References: <0835B3720019904CB8F7AA43166CEEB201051D51@RTITMBSV03.realtek.com.tw> <95fa9f67-3af6-6749-0e2b-c95406486f7d@pobox.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 24 Nov 2016 07:19:44 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 702 Lines: 19 From: Mark Lord Date: Thu, 24 Nov 2016 07:31:17 -0500 > Any way we look at it though, the chip/driver are simply unreliable, > and relying upon hardware checksums (which fail due to the driver > looking at garbage rather than the checksum bits) leads to data > corruption. If the cpu/DMA implementation is the problem, then turning off checksums is not an appropriate fix at all. In fact, we have no idea what the cause is yet. That makes turning off random features no more than grasping at straws and makes no sense at all upstream. It may make sense for you to do such a change locally in _your_ tree to fix your situation temporarily. But upstream we shouldn't be doing it.