Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757331AbcKXQnp (ORCPT ); Thu, 24 Nov 2016 11:43:45 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:40043 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757238AbcKXQnn (ORCPT ); Thu, 24 Nov 2016 11:43:43 -0500 Date: Thu, 24 Nov 2016 09:43:31 -0700 From: Jason Gunthorpe To: Nayna Cc: tpmdd-devel@lists.sourceforge.net, peterhuewe@gmx.de, tpmdd@selhorst.net, jarkko.sakkinen@linux.intel.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/3] tpm: move event log init functions to tpm_eventlog_init.c Message-ID: <20161124164331.GA4930@obsidianresearch.com> References: <1479922057-8752-1-git-send-email-nayna@linux.vnet.ibm.com> <1479922057-8752-2-git-send-email-nayna@linux.vnet.ibm.com> <20161123193830.GB13927@obsidianresearch.com> <58369E3F.40509@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58369E3F.40509@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 617 Lines: 19 On Thu, Nov 24, 2016 at 01:31:03PM +0530, Nayna wrote: > >>Since the initialization functions are common with the TPM 2.0 event > >>log support, this patch splits tpm_eventlog.c to have only TPM 1.2 > >>event log parsing logic and moves the init functions into > >>tpm_eventlog_init.c. > > > >I think I'd rather see a tpm_eventlog1.c/tpm_eventlog2.c than this > >_init thing.. > > Do you mean tpm_eventlog1.c for TPM 1.2 and tpm_eventlog2.c for TPM 2.0 > event log specific parsing ? > > And if so, then which one should have the common functions for TPM 1.2 and > TPM 2.0? Leave them in tpm_eventlog.c .. Jason