Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935132AbcKXRnP convert rfc822-to-8bit (ORCPT ); Thu, 24 Nov 2016 12:43:15 -0500 Received: from mail.sigma-star.at ([95.130.255.111]:45996 "EHLO mail.sigma-star.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933424AbcKXRnO (ORCPT ); Thu, 24 Nov 2016 12:43:14 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: [PATCH 02/29] fscrypt: Allow fscrypt_decrypt_page() to function with non-writeback pages From: David Gstir In-Reply-To: <20161115181939.GB127180@google.com> Date: Thu, 24 Nov 2016 18:43:14 +0100 Cc: Richard Weinberger , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, dedekind1@gmail.com, adrian.hunter@intel.com, tytso@mit.edu, jaegeuk@kernel.org, wd@denx.de, sbabic@denx.de, dengler@linutronix.de, mhalcrow@google.com, hch@infradead.org Content-Transfer-Encoding: 8BIT Message-Id: References: <1479072072-6844-1-git-send-email-richard@nod.at> <1479072072-6844-3-git-send-email-richard@nod.at> <20161115181939.GB127180@google.com> To: Eric Biggers X-Mailer: Apple Mail (2.3124) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 616 Lines: 19 Eric, > On 15.11.2016, at 19:19, Eric Biggers wrote: > > On Sun, Nov 13, 2016 at 10:20:45PM +0100, Richard Weinberger wrote: >> /** >> * f2crypt_decrypt_page() - Decrypts a page in-place >> - * @page: The page to decrypt. Must be locked. >> + * @inode: The encrypted inode to decrypt. >> + * @page: The page to decrypt. Must be locked. > > Strictly speaking, it's not the inode itself being decrypted, but rather the > data associated with it. Could this be better expressed as something like > "The inode to which the page belongs"? Yes, you're right. Will address that! Thanks, David