Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941256AbcKXTB5 (ORCPT ); Thu, 24 Nov 2016 14:01:57 -0500 Received: from mail-yw0-f195.google.com ([209.85.161.195]:35652 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935677AbcKXTBz (ORCPT ); Thu, 24 Nov 2016 14:01:55 -0500 MIME-Version: 1.0 In-Reply-To: <645cf6ab-73dd-4eec-e619-9df13e1e345b@mailbox.org> References: <1479924629-20231-1-git-send-email-sergio.paracuellos@gmail.com> <1479924629-20231-3-git-send-email-sergio.paracuellos@gmail.com> <645cf6ab-73dd-4eec-e619-9df13e1e345b@mailbox.org> From: Sergio Paracuellos Date: Thu, 24 Nov 2016 20:01:54 +0100 Message-ID: Subject: Re: [PATCH 2/2] staging: slicoss: replace UPDATE_STATS_GB macro into an inline function To: =?UTF-8?Q?Markus_B=C3=B6hme?= Cc: Greg KH , devel@driverdev.osuosl.org, linux-kernel , Lior Dotan Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uAOJ27IJ014455 Content-Length: 1731 Lines: 44 On Wed, Nov 23, 2016 at 11:32 PM, Markus Böhme wrote: > On 11/23/2016 08:00 PM, Markus Böhme wrote: >> On 11/23/2016 07:10 PM, Sergio Paracuellos wrote: >>> This patch replaces UPDATE_STATS_GB macro in slic.h header file >>> into an inline function. This provides type safety and readability. >>> >>> Signed-off-by: Sergio Paracuellos >>> --- >>> drivers/staging/slicoss/slic.h | 6 ++--- >>> drivers/staging/slicoss/slicoss.c | 56 ++++++++++++++++++++------------------- >>> 2 files changed, 32 insertions(+), 30 deletions(-) >>> >>> diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h >>> index 2c05868..b19ddc9 100644 >>> --- a/drivers/staging/slicoss/slic.h >>> +++ b/drivers/staging/slicoss/slic.h >>> @@ -548,9 +548,9 @@ static inline void slic_flush_write(struct adapter *adapter) >>> ioread32(adapter->regs + SLIC_REG_HOSTID); >>> } >>> >>> -#define UPDATE_STATS_GB(largestat, newstat, oldstat) \ >>> -{ \ >>> - (largestat) += ((newstat) - (oldstat)); \ >>> +static inline u64 update_stats_gb(const u64 newstat, const u64 oldstat) >>> +{ >>> + return (newstat - oldstat); >>> } >>> >> >> I suggest dropping the parentheses here. They are unnecessary and likely >> to lead to a cleanup patch. >> > > Giving it a second thought, perhaps one should do without this > macro/function and just inline the calculation. IMO this would improve > readability even more. I see. Ok, I'll remove this inline function and macro and send a V2 patchset with just the calculation inlined. Thanks, Sergio Paracuellos